-
Notifications
You must be signed in to change notification settings - Fork 17.9k
Ml patch 2 #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Ml patch 2 #869
Conversation
initial learning
visualizaion
polynomial Regression
regression
… into ML-Patch-2
Ml patch 2
… into ML-Patch-2
Ml patch 2
… into ML-Patch-2
Ml patch 2
… into ML-Patch-2
Ml patch 2
… into ML-Patch-2
Ml patch 2
… into ML-Patch-2
@PaskalSunari please ensure you complete the pull request template so we can validate what the request changes are? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a comprehensive machine learning curriculum covering cuisine classification, UFO sighting analysis, and pumpkin price regression. The changes focus on developing practical ML models and web applications to demonstrate real-world applications of classification and regression techniques.
- Adds complete cuisine classifier with ONNX model export for web deployment
- Implements UFO sighting prediction system using logistic regression with pickle serialization
- Creates pumpkin price regression analysis with data visualization and preparation
Reviewed Changes
Copilot reviewed 11 out of 18 changed files in this pull request and generated 8 comments.
Show a summary per file
File | Description |
---|---|
4-Classification/4-Applied/notebook.ipynb | Complete notebook implementing SVM cuisine classifier with ONNX model export for web deployment |
4-Classification/4-Applied/index.html | Web interface for cuisine recommendation with ingredient selection checkboxes |
4-Classification/4-Applied/CouisineMatcher.js | JavaScript implementation handling user input and ONNX model inference for cuisine prediction |
4-Classification/4-Applied/styles.css | CSS styling for the web application interface |
4-Classification/3-Classifiers-2/notebook.ipynb | Comparative analysis of multiple classification algorithms (SVM, KNN, Random Forest, AdaBoost) |
4-Classification/2-Classifiers-1/notebook.ipynb | Logistic regression implementation for cuisine classification with probability analysis |
3-Web-App/1-Web-App/notebook.ipynb | UFO sighting prediction model using logistic regression with confusion matrix analysis |
3-Web-App/1-Web-App/solution/notebook.ipynb | Enhanced UFO prediction model with improved accuracy and pickle model serialization |
2-Regression/2-Data/notebook.ipynb | Pumpkin price dataset preparation and exploratory data analysis with visualization |
2-Regression/1-Tools/notebook.ipynb | Introduction to NumPy arrays and machine learning tools setup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
} | ||
], | ||
"source": [ | ||
"cusisines_features_df = cuisines_df.drop(['Unnamed: 0', 'cuisine'], axis=1)\n", |
Copilot
AI
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable name should be 'cuisines_features_df' to correctly spell 'cuisines'.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PaskalSunari please fix
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 18 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (2)
3-Web-App/1-Web-App/solution/notebook.ipynb:1
- There's a stray 'z' character at the end of the comment.
{
2-Regression/2-Data/notebook.ipynb:1
- Variable name contains a typo: 'pumkinns' should be 'pumpkins'.
{
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@@ -0,0 +1,46 @@ | |||
// Test alert message to verify JavaScript is working | |||
|
|||
const ingredients = Array(380).fill(0); |
Copilot
AI
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The number 380 should be defined as a named constant (e.g., const TOTAL_INGREDIENTS = 380
) to improve code maintainability and make the purpose clearer.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PaskalSunari please fix
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 18 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
2-Regression/2-Data/notebook.ipynb:1
- Variable name 'new_pumkinns' appears to be a typo, should likely be 'new_pumpkins' to match the DataFrame created earlier.
{
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@@ -0,0 +1,46 @@ | |||
// Handles ingredient selection and cuisine prediction using an ONNX model. |
Copilot
AI
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'Couisine' to 'Cuisine' in filename.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PaskalSunari please fix
Co-authored-by: Copilot <[email protected]>
No description provided.