Fix removeRange in InMemoryProvider #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Microsoft" Note : I spooke with Eliran about that. |
eliranek1
reviewed
Jun 6, 2025
|
Done @eliranek1 |
thomastay
requested changes
Jun 6, 2025
eliranek1
previously approved these changes
Jun 9, 2025
thomastay
requested changes
Jun 16, 2025
There was a problem hiding this comment.
Hi @BertholetDamien I did some local testing and it seems to work now for non-unique indices. Thanks for making the changes!
Can you guard this behind a FF, then i think it is good for checkin
thomastay
previously approved these changes
Jun 17, 2025
eliranek1
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoveRange was not working in InMemoryProvider when an index was used.
Because getKeysForRange was returning the index's key and not the primary index's key.