FIX parse likert raw score via float before int#2133
Merged
romanlutz merged 2 commits intoJul 8, 2026
Conversation
SelfAskLikertScorer crashed with ValueError when a judge returns a numeric likert value like "4.0" (float() accepts it, int() does not). Parse the likert_value metadata via float first, matching the score-value line. +test. Signed-off-by: WatchTree-19 <119982314+WatchTree-19@users.noreply.github.com>
romanlutz
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
SelfAskLikertScorerraisesValueErrorwhen the judge returns a numeric likert value with a decimal point (e.g."4.0"), which models commonly do for a "numeric value between 1 and 5".in
_score_asyncthe raw value is parsed two different ways:float(unvalidated_score.raw_score_value)int(unvalidated_score.raw_score_value)raw_score_valueisstr(parsed_response["score_value"]), so a judge response of4.0becomes"4.0".float("4.0")is fine, butint("4.0")raisesValueError: invalid literal for int() with base 10: '4.0', so the whole score fails even though the float-scaled value computed correctly.SelfAskScaleScorerdoesn't hit this because it neverint()s the raw value.fix
parse the metadata via
floatfirst, matching the score-value line:test
added
test_likert_scorer_accepts_float_string_score_value(judge returnsscore_value: "4.0"). fails onmain(ValueError), passes with the fix, and asserts thelikert_valuemetadata is4. fulltests/unit/score/test_self_ask_likert.py34 pass;ruff check+ruff formatclean.found by reading the scorer, not from the tracker. happy to file an issue first if you'd prefer.