Fix unsound Array.concat() typings #33620
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jablko we can't merge all these PRs independently - please make a roll-up PR with all the concat changes in one so we can actually test them. There should also be a unified test suite that clearly outlines the behaviors you want to change. |
|
@RyanCavanaugh Sure thing: I've now created #33645 combining all of the Array.concat() changes |
jablko
force-pushed
the
patch-11
branch
3 times, most recently
from
c502726 to
bd3b22e
Compare
jablko
force-pushed
the
patch-11
branch
3 times, most recently
from
659822c to
f4e78a6
Compare
jablko
force-pushed
the
patch-11
branch
3 times, most recently
from
7a5a93f to
d8c12f7
Compare
jablko
force-pushed
the
patch-11
branch
3 times, most recently
from
0b7fa2f to
0ef07be
Compare
jablko
force-pushed
the
patch-11
branch
5 times, most recently
from
7441f84 to
6194c9d
Compare
jablko
force-pushed
the
patch-11
branch
3 times, most recently
from
1fb40ca to
f26c007
Compare
|
Rolled into #33645 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19535