-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Deprioritize inferences made from implicit never arrays #54006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Deprioritize inferences made from implicit never arrays #54006
Conversation
…itive type parameter constraints
149870c
to
f050215
Compare
@typescript-bot test this |
Heya @weswigham, I've started to run the extended test suite on this PR at f050215. You can monitor the build here. |
Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at f050215. You can monitor the build here. Update: The results are in! |
Heya @weswigham, I've started to run the perf test suite on this PR at f050215. You can monitor the build here. Update: The results are in! |
Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at f050215. You can monitor the build here. Update: The results are in! |
@weswigham Here they are:
CompilerComparison Report - main..54006
System
Hosts
Scenarios
TSServerComparison Report - main..54006
System
Hosts
Scenarios
StartupComparison Report - main..54006
System
Hosts
Scenarios
Developer Information: |
@weswigham Here are the results of running the top-repos suite comparing Everything looks good! |
Hey @weswigham, the results of running the DT tests are ready. |
…n-of-some-mapped-type-inferences
@Andarist A much better fix, IMO, would be to deprioritize inferences from the So.... toss in a new |
0bc03aa
to
7cb45d5
Compare
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
@weswigham I've pushed out the requested changes. The problem wasn't quite about |
fixes #54000
it tweaks the logic introduced in #44126 , cc @weswigham