Cache repeated mapper instantiations only within a single instantiation call #61535

Andarist · 2025-04-05T14:08:46Z

This is an alternative to #61505 , I hope this might have better memory consumption characteristics (at the expense of repeated work, the instantiations diff can be seen here).

typescript-bot · 2025-04-05T14:08:51Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

…on call

jakebailey · 2025-04-05T15:00:35Z

@typescript-bot test it

typescript-bot · 2025-04-05T15:00:40Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-04-05T15:23:05Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-04-05T15:30:50Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61535/merge:

Everything looks good!

typescript-bot · 2025-04-05T15:47:38Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,593k (± 0.75%)}	_{194,212k (± 0.94%)}	_~	_192,911k	_196,559k	_{p=0.173 n=6}
_{Parse Time}	_{1.31s (± 0.68%)}	_{1.32s (± 0.42%)}	_~	_1.31s	_1.32s	_{p=0.341 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.73s (± 0.25%)}	_{9.76s (± 0.26%)}	_~	_9.72s	_9.78s	_{p=0.122 n=6}
_{Emit Time}	_{2.73s (± 0.43%)}	_{2.73s (± 0.44%)}	_~	_2.71s	_2.74s	_{p=0.502 n=6}
_{Total Time}	_{14.50s (± 0.21%)}	_{14.53s (± 0.12%)}	_~	_14.50s	_14.55s	_{p=0.142 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₆	₅₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,670	_948,670	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,947	_410,947	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,306k (± 0.01%)}	_{1,224,405k (± 0.01%)}	_{+99k (+ 0.01%)}	_1,224,325k	_1,224,519k	_{p=0.045 n=6}
_{Parse Time}	_{6.67s (± 0.53%)}	_{6.63s (± 0.95%)}	_~	_6.52s	_6.69s	_{p=0.295 n=6}
_{Bind Time}	_{1.89s (± 0.54%)}	_{1.88s (± 0.62%)}	_~	_1.87s	_1.90s	_{p=0.117 n=6}
_{Check Time}	_{31.90s (± 0.19%)}	_{32.08s (± 0.27%)}	_{+0.18s (+ 0.55%)}	_31.97s	_32.20s	_{p=0.006 n=6}
_{Emit Time}	_{15.31s (± 0.25%)}	_{15.27s (± 0.32%)}	_~	_15.19s	_15.33s	_{p=0.172 n=6}
_{Total Time}	_{55.78s (± 0.18%)}	_{55.86s (± 0.31%)}	_~	_55.56s	_56.06s	_{p=0.378 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,460,251	_2,460,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_892,981	_892,981	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,308,123k (± 0.00%)}	_{2,308,868k (± 0.00%)}	_{+745k (+ 0.03%)}	_2,308,843k	_2,308,929k	_{p=0.005 n=6}
_{Parse Time}	_{9.03s (± 0.26%)}	_{9.00s (± 0.16%)}	_{-0.03s (- 0.37%)}	_8.97s	_9.01s	_{p=0.011 n=6}
_{Bind Time}	_{2.26s (± 0.46%)}	_{2.27s (± 0.39%)}	_~	_2.26s	_2.28s	_{p=0.344 n=6}
_{Check Time}	_{75.82s (± 0.30%)}	_{75.82s (± 0.55%)}	_~	_75.14s	_76.27s	_{p=0.810 n=6}
_{Emit Time}	_0.29s	_0.29s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{87.41s (± 0.25%)}	_{87.38s (± 0.49%)}	_~	_86.67s	_87.83s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,719	_1,226,771	_{+52 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,996	_267,003	_{+7 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,357,318k (± 0.02%)}	_{2,357,853k (± 0.03%)}	_~	_2,356,787k	_2,359,113k	_{p=0.173 n=6}
_{Parse Time}	_{5.19s (± 1.21%)}	_{5.20s (± 0.98%)}	_~	_5.14s	_5.29s	_{p=0.810 n=6}
_{Bind Time}	_{1.79s (± 1.66%)}	_{1.78s (± 1.40%)}	_~	_1.74s	_1.81s	_{p=0.624 n=6}
_{Check Time}	_{35.34s (± 0.26%)}	_{35.45s (± 0.25%)}	_~	_35.35s	_35.59s	_{p=0.093 n=6}
_{Emit Time}	_{3.08s (± 3.18%)}	_{3.00s (± 2.32%)}	_~	_2.93s	_3.12s	_{p=0.091 n=6}
_{Total Time}	_{45.41s (± 0.25%)}	_{45.44s (± 0.35%)}	_~	_45.23s	_45.64s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,719	_1,226,771	_{+52 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,996	_267,003	_{+7 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,153,487k (± 0.03%)}	_{2,912,205k (±12.87%)}	_~	_2,426,444k	_3,154,877k	_{p=1.000 n=6}
_{Parse Time}	_{7.03s (± 0.85%)}	_{6.96s (± 1.32%)}	_~	_6.83s	_7.09s	_{p=0.199 n=6}
_{Bind Time}	_{2.16s (± 1.22%)}	_{2.15s (± 1.36%)}	_~	_2.10s	_2.18s	_{p=0.810 n=6}
_{Check Time}	_{42.97s (± 0.43%)}	_{43.09s (± 0.57%)}	_~	_42.76s	_43.51s	_{p=0.471 n=6}
_{Emit Time}	_{3.52s (± 1.38%)}	_{3.57s (± 4.16%)}	_~	_3.29s	_3.72s	_{p=0.128 n=6}
_{Total Time}	_{55.67s (± 0.35%)}	_{55.78s (± 0.71%)}	_~	_55.07s	_56.29s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,674	_262,726	_{+52 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,849	_106,856	_{+7 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{440,482k (± 0.01%)}	_{440,492k (± 0.01%)}	_~	_440,461k	_440,542k	_{p=1.000 n=6}
_{Parse Time}	_{3.57s (± 0.84%)}	_{3.52s (± 0.66%)}	_{-0.06s (- 1.59%)}	_3.48s	_3.54s	_{p=0.013 n=6}
_{Bind Time}	_{1.32s (± 0.83%)}	_{1.32s (± 0.39%)}	_~	_1.31s	_1.32s	_{p=0.784 n=6}
_{Check Time}	_{18.93s (± 0.47%)}	_{19.03s (± 0.36%)}	_{+0.11s (+ 0.56%)}	_18.93s	_19.11s	_{p=0.044 n=6}
_{Emit Time}	_{1.52s (± 0.93%)}	_{1.52s (± 1.46%)}	_~	_1.48s	_1.54s	_{p=0.622 n=6}
_{Total Time}	_{25.34s (± 0.36%)}	_{25.39s (± 0.34%)}	_~	_25.28s	_25.51s	_{p=0.336 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,981	_225,981	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,356	_94,356	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,331k (± 0.06%)}	_{371,235k (± 0.01%)}	_~	_371,197k	_371,292k	_{p=0.630 n=6}
_{Parse Time}	_{2.89s (± 1.30%)}	_{2.91s (± 1.20%)}	_~	_2.87s	_2.97s	_{p=0.195 n=6}
_{Bind Time}	_{1.61s (± 1.36%)}	_{1.59s (± 0.65%)}	_~	_1.58s	_1.61s	_{p=0.100 n=6}
_{Check Time}	_{16.48s (± 0.33%)}	_{16.54s (± 0.47%)}	_~	_16.40s	_16.63s	_{p=0.106 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.97s (± 0.46%)}	_{21.04s (± 0.46%)}	_~	_20.89s	_21.19s	_{p=0.334 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,337,504	_3,337,504	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,131,017	_1,131,017	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,395,657k (± 0.00%)}	_{3,395,597k (± 0.01%)}	_~	_3,395,235k	_3,395,759k	_{p=0.936 n=6}
_{Parse Time}	_{14.56s (± 0.46%)}	_{14.62s (± 0.77%)}	_~	_14.45s	_14.76s	_{p=0.335 n=6}
_{Bind Time}	_{4.62s (± 0.60%)}	_{4.62s (± 0.40%)}	_~	_4.59s	_4.64s	_{p=0.936 n=6}
_{Check Time}	_{90.93s (± 1.39%)}	_{91.76s (± 1.63%)}	_~	_90.56s	_93.91s	_{p=0.229 n=6}
_{Emit Time}	_{29.16s (± 0.36%)}	_{29.38s (± 2.10%)}	_~	_28.93s	_30.53s	_{p=0.688 n=6}
_{Total Time}	_{139.27s (± 0.93%)}	_{140.38s (± 1.35%)}	_~	_138.86s	_143.60s	_{p=0.230 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_311,741	_311,741	_~	_~	_~	_{p=1.000 n=6}
_Types	_137,137	_137,137	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{466,660k (± 0.01%)}	_{466,577k (± 0.02%)}	_~	_466,517k	_466,711k	_{p=0.093 n=6}
_{Parse Time}	_{5.13s (± 0.98%)}	_{5.11s (± 0.20%)}	_~	_5.10s	_5.13s	_{p=1.000 n=6}
_{Bind Time}	_{2.27s (± 0.82%)}	_{2.27s (± 0.53%)}	_~	_2.25s	_2.28s	_{p=0.463 n=6}
_{Check Time}	_{25.49s (± 0.22%)}	_{25.50s (± 0.40%)}	_~	_25.39s	_25.63s	_{p=0.936 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=1.000 n=6}
_{Total Time}	_{32.89s (± 0.27%)}	_{32.88s (± 0.31%)}	_~	_32.78s	_33.02s	_{p=1.000 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_567,397	_567,397	_~	_~	_~	_{p=1.000 n=6}
_Types	_190,073	_190,073	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{497,982k (± 0.01%)}	_{499,595k (± 0.01%)}	_{+1,613k (+ 0.32%)}	_499,546k	_499,633k	_{p=0.005 n=6}
_{Parse Time}	_{3.35s (± 0.62%)}	_{3.37s (± 0.89%)}	_~	_3.33s	_3.42s	_{p=0.568 n=6}
_{Bind Time}	_{1.21s (± 1.35%)}	_{1.21s (± 1.32%)}	_~	_1.18s	_1.22s	_{p=0.742 n=6}
_{Check Time}	_{20.03s (± 0.28%)}	_{19.55s (± 0.24%)}	_{-0.47s (- 2.36%)}	_19.50s	_19.61s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.59s (± 0.33%)}	_{24.13s (± 0.20%)}	_{-0.46s (- 1.86%)}	_24.05s	_24.17s	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-04-05T16:28:32Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61535/merge:

Everything looks good!

Andarist · 2025-04-05T17:00:43Z

FWIW, check times for AnswerOverflow/AnswerOverflow/apps/dashboard:

TS 5.8

6.44
6.58
6.99
6.33
7.00

PR #61505 at commit a6a728f

3.25
3.34
3.21
3.24
3.43

This PR (#61535) at commit 82666d1:

3.22
3.18
3.22
3.18
3.43

Andarist added 11 commits March 29, 2025 18:25

Cache instantiated object alias type arguments on mapper

e337be1

Move the cache to instantiateTypeWithAlias

cb3b721

disable cache on function mappers

6d4258b

tweak cache key

f07db72

add sanity checks

e2e7091

only disable cache on certain makeFunctionTypeMappers

b0f5c70

fmt

31925e7

fix an instance of reusing bad cached value

a040139

relax restrictiveMapper caching restriction

22520da

replace voidMap with emptyMap

051c8bd

fmt

a6a728f

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 5, 2025

Andarist mentioned this pull request Apr 5, 2025

Cache mapper instantiations #61505

Open

Cache repeated mapper instantiations only within a single instantiati…

82666d1

…on call

Andarist force-pushed the cache-mapper-instaniations-limited branch from 5b50238 to 82666d1 Compare April 5, 2025 14:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cache repeated mapper instantiations only within a single instantiation call #61535

Cache repeated mapper instantiations only within a single instantiation call #61535

Andarist commented Apr 5, 2025

typescript-bot commented Apr 5, 2025

jakebailey commented Apr 5, 2025

typescript-bot commented Apr 5, 2025 •

edited

Loading

typescript-bot commented Apr 5, 2025

typescript-bot commented Apr 5, 2025

typescript-bot commented Apr 5, 2025

tsc

typescript-bot commented Apr 5, 2025

Andarist commented Apr 5, 2025

Cache repeated mapper instantiations only within a single instantiation call #61535

Are you sure you want to change the base?

Cache repeated mapper instantiations only within a single instantiation call #61535

Conversation

Andarist commented Apr 5, 2025

typescript-bot commented Apr 5, 2025

jakebailey commented Apr 5, 2025

typescript-bot commented Apr 5, 2025 • edited Loading

typescript-bot commented Apr 5, 2025

typescript-bot commented Apr 5, 2025

typescript-bot commented Apr 5, 2025

tsc

typescript-bot commented Apr 5, 2025

Andarist commented Apr 5, 2025

typescript-bot commented Apr 5, 2025 •

edited

Loading