Skip to content

LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251125204230298 to main #62805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+126 −0
Open

LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20251125204230298 to main #62805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/loc/lcl/cht/diagnosticMessages/diagnosticMessages.generated.json.lcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18630,6 +18630,15 @@
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";await_using_declarations_are_not_allowed_in_case_or_default_clauses_unless_contained_within_a_block_1548" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['await using' declarations are not allowed in 'case' or 'default' clauses unless contained within a block.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[除非包含在區塊內，否則 'case' 或 'default' 子句中不允許 'await using' 宣告。]]></Val>
</Tgt>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";await_using_statements_are_only_allowed_at_the_top_level_of_a_file_when_that_file_is_a_module_but_th_2853" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['await using' statements are only allowed at the top level of a file when that file is a module, but this file has no imports or exports. Consider adding an empty 'export {}' to make this file a module.]]></Val>
Expand Down Expand Up @@ -19494,6 +19503,15 @@
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";using_declarations_are_not_allowed_in_case_or_default_clauses_unless_contained_within_a_block_1547" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['using' declarations are not allowed in 'case' or 'default' clauses unless contained within a block.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[除非包含在區塊內，否則 'case' 或 'default' 子句中不允許 'using' 宣告。]]></Val>
</Tgt>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";with_statements_are_not_allowed_in_an_async_function_block_1300" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['with' statements are not allowed in an async function block.]]></Val>
Expand Down
18 changes: 18 additions & 0 deletions src/loc/lcl/deu/diagnosticMessages/diagnosticMessages.generated.json.lcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18624,6 +18624,15 @@
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";await_using_declarations_are_not_allowed_in_case_or_default_clauses_unless_contained_within_a_block_1548" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['await using' declarations are not allowed in 'case' or 'default' clauses unless contained within a block.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[„Await using“-Deklarationen sind in „Case“- oder „Default“-Klauseln nur zulässig, wenn sie in einem Block enthalten sind.]]></Val>
</Tgt>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";await_using_statements_are_only_allowed_at_the_top_level_of_a_file_when_that_file_is_a_module_but_th_2853" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['await using' statements are only allowed at the top level of a file when that file is a module, but this file has no imports or exports. Consider adding an empty 'export {}' to make this file a module.]]></Val>
Expand Down Expand Up @@ -19488,6 +19497,15 @@
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";using_declarations_are_not_allowed_in_case_or_default_clauses_unless_contained_within_a_block_1547" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['using' declarations are not allowed in 'case' or 'default' clauses unless contained within a block.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[„Using“-Deklarationen sind in „Case“- oder „Default“-Klauseln nur zulässig, wenn sie in einem Block enthalten sind.]]></Val>
</Tgt>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";with_statements_are_not_allowed_in_an_async_function_block_1300" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['with' statements are not allowed in an async function block.]]></Val>
Expand Down
18 changes: 18 additions & 0 deletions src/loc/lcl/esn/diagnosticMessages/diagnosticMessages.generated.json.lcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18642,6 +18642,15 @@
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";await_using_declarations_are_not_allowed_in_case_or_default_clauses_unless_contained_within_a_block_1548" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['await using' declarations are not allowed in 'case' or 'default' clauses unless contained within a block.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Las declaraciones "await using" no se permiten en las cláusulas "case" o "default", a menos que estén contenidas en un bloque.]]></Val>
</Tgt>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";await_using_statements_are_only_allowed_at_the_top_level_of_a_file_when_that_file_is_a_module_but_th_2853" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['await using' statements are only allowed at the top level of a file when that file is a module, but this file has no imports or exports. Consider adding an empty 'export {}' to make this file a module.]]></Val>
Expand Down Expand Up @@ -19506,6 +19515,15 @@
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";using_declarations_are_not_allowed_in_case_or_default_clauses_unless_contained_within_a_block_1547" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['using' declarations are not allowed in 'case' or 'default' clauses unless contained within a block.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Las declaraciones "using" no se permiten en las cláusulas "case" o "default", a menos que estén contenidas en un bloque.]]></Val>
</Tgt>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";with_statements_are_not_allowed_in_an_async_function_block_1300" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['with' statements are not allowed in an async function block.]]></Val>
Expand Down
18 changes: 18 additions & 0 deletions src/loc/lcl/fra/diagnosticMessages/diagnosticMessages.generated.json.lcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18642,6 +18642,15 @@
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";await_using_declarations_are_not_allowed_in_case_or_default_clauses_unless_contained_within_a_block_1548" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['await using' declarations are not allowed in 'case' or 'default' clauses unless contained within a block.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Les déclarations 'await using' ne sont pas autorisées dans les clauses 'case' ou 'default', sauf si elles sont contenues dans un bloc.]]></Val>
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The French translation is inconsistent with quote marks. The existing translation for error 1546 at line 18640 uses guillemet quotes (« await using »), but the new translation for error 1548 uses regular single quotes ('await using'). For consistency, line 18649 should use:

Les déclarations « await using » ne sont pas autorisées dans les clauses « case » ou « default », sauf si elles sont contenues dans un bloc.

This maintains consistency with the existing French localization style.

Copilot uses AI. Check for mistakes.
</Tgt>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";await_using_statements_are_only_allowed_at_the_top_level_of_a_file_when_that_file_is_a_module_but_th_2853" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['await using' statements are only allowed at the top level of a file when that file is a module, but this file has no imports or exports. Consider adding an empty 'export {}' to make this file a module.]]></Val>
Expand Down Expand Up @@ -19506,6 +19515,15 @@
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";using_declarations_are_not_allowed_in_case_or_default_clauses_unless_contained_within_a_block_1547" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['using' declarations are not allowed in 'case' or 'default' clauses unless contained within a block.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Les déclarations 'using' ne sont pas autorisées dans les clauses 'case' ou 'default' sauf si elles sont incluses dans un bloc.]]></Val>
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The French translation is inconsistent with quote marks. The existing translation for error 1545 at line 19513 uses guillemet quotes (« using »), but the new translation for error 1547 uses regular single quotes ('using'). For consistency, line 19522 should use:

Les déclarations « using » ne sont pas autorisées dans les clauses « case » ou « default » sauf si elles sont incluses dans un bloc.

This maintains consistency with the existing French localization style.

Copilot uses AI. Check for mistakes.
</Tgt>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";with_statements_are_not_allowed_in_an_async_function_block_1300" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['with' statements are not allowed in an async function block.]]></Val>
Expand Down
18 changes: 18 additions & 0 deletions src/loc/lcl/kor/diagnosticMessages/diagnosticMessages.generated.json.lcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18630,6 +18630,15 @@
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";await_using_declarations_are_not_allowed_in_case_or_default_clauses_unless_contained_within_a_block_1548" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['await using' declarations are not allowed in 'case' or 'default' clauses unless contained within a block.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA['await using' 선언은 블록 내에 포함되지 않는 한 'case' 또는 'default' 조항에서는 허용되지 않습니다.]]></Val>
</Tgt>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";await_using_statements_are_only_allowed_at_the_top_level_of_a_file_when_that_file_is_a_module_but_th_2853" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['await using' statements are only allowed at the top level of a file when that file is a module, but this file has no imports or exports. Consider adding an empty 'export {}' to make this file a module.]]></Val>
Expand Down Expand Up @@ -19494,6 +19503,15 @@
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";using_declarations_are_not_allowed_in_case_or_default_clauses_unless_contained_within_a_block_1547" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['using' declarations are not allowed in 'case' or 'default' clauses unless contained within a block.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA['using' 선언은 블록 내에 포함되지 않는 한 'case' 또는 'default' 조항에서는 허용되지 않습니다.]]></Val>
</Tgt>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";with_statements_are_not_allowed_in_an_async_function_block_1300" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['with' statements are not allowed in an async function block.]]></Val>
Expand Down
18 changes: 18 additions & 0 deletions src/loc/lcl/ptb/diagnosticMessages/diagnosticMessages.generated.json.lcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18620,6 +18620,15 @@
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";await_using_declarations_are_not_allowed_in_case_or_default_clauses_unless_contained_within_a_block_1548" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['await using' declarations are not allowed in 'case' or 'default' clauses unless contained within a block.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Declarações "await using" não são permitidas em cláusulas "case" ou "default", a menos que estejam contidas em um bloco.]]></Val>
</Tgt>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";await_using_statements_are_only_allowed_at_the_top_level_of_a_file_when_that_file_is_a_module_but_th_2853" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['await using' statements are only allowed at the top level of a file when that file is a module, but this file has no imports or exports. Consider adding an empty 'export {}' to make this file a module.]]></Val>
Expand Down Expand Up @@ -19484,6 +19493,15 @@
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";using_declarations_are_not_allowed_in_case_or_default_clauses_unless_contained_within_a_block_1547" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['using' declarations are not allowed in 'case' or 'default' clauses unless contained within a block.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Declarações "using" não são permitidas em cláusulas "case" ou "default", a menos que estejam contidas em um bloco.]]></Val>
</Tgt>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";with_statements_are_not_allowed_in_an_async_function_block_1300" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['with' statements are not allowed in an async function block.]]></Val>
Expand Down
18 changes: 18 additions & 0 deletions src/loc/lcl/rus/diagnosticMessages/diagnosticMessages.generated.json.lcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18629,6 +18629,15 @@
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";await_using_declarations_are_not_allowed_in_case_or_default_clauses_unless_contained_within_a_block_1548" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['await using' declarations are not allowed in 'case' or 'default' clauses unless contained within a block.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Объявления "await using" не разрешены в предложениях "case" или "default", если они не находятся внутри блока.]]></Val>
</Tgt>
</Str>
<Disp Icon="Str" />
</Item>
Comment on lines +18632 to +18640
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only includes localizations for 7 out of 13 supported languages. The following language files are missing the new diagnostic messages for error codes 1547 and 1548:

  • src/loc/lcl/chs/diagnosticMessages/diagnosticMessages.generated.json.lcl (Chinese Simplified)
  • src/loc/lcl/csy/diagnosticMessages/diagnosticMessages.generated.json.lcl (Czech)
  • src/loc/lcl/ita/diagnosticMessages/diagnosticMessages.generated.json.lcl (Italian)
  • src/loc/lcl/jpn/diagnosticMessages/diagnosticMessages.generated.json.lcl (Japanese)
  • src/loc/lcl/plk/diagnosticMessages/diagnosticMessages.generated.json.lcl (Polish)
  • src/loc/lcl/trk/diagnosticMessages/diagnosticMessages.generated.json.lcl (Turkish)

These files should be updated to include the same two new diagnostic messages:

  1. await_using_declarations_are_not_allowed_in_case_or_default_clauses_unless_contained_within_a_block_1548
  2. using_declarations_are_not_allowed_in_case_or_default_clauses_unless_contained_within_a_block_1547

The localized entries should follow the same XML structure and placement as seen in the already-updated language files.

Copilot uses AI. Check for mistakes.
<Item ItemId=";await_using_statements_are_only_allowed_at_the_top_level_of_a_file_when_that_file_is_a_module_but_th_2853" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['await using' statements are only allowed at the top level of a file when that file is a module, but this file has no imports or exports. Consider adding an empty 'export {}' to make this file a module.]]></Val>
Expand Down Expand Up @@ -19493,6 +19502,15 @@
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";using_declarations_are_not_allowed_in_case_or_default_clauses_unless_contained_within_a_block_1547" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['using' declarations are not allowed in 'case' or 'default' clauses unless contained within a block.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Объявления "using" не разрешены в предложениях "case" или "default", если они не находятся внутри блока.]]></Val>
</Tgt>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";with_statements_are_not_allowed_in_an_async_function_block_1300" ItemType="0" PsrId="306" Leaf="true">
<Str Cat="Text">
<Val><![CDATA['with' statements are not allowed in an async function block.]]></Val>
Expand Down