fix(agent-os): enforce TLS for configured MCP URLs - #3793
Open
Artem (pararti) wants to merge 1 commit into
Open
Conversation
Signed-off-by: Artem Parshin <me@apararti.ru>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Welcome to the Agent Governance Toolkit! Thanks for your first pull request. |
PR Review Summary
Verdict: AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims. |
Author
|
@microsoft-github-policy-service agree |
Artem (pararti)
marked this pull request as ready for review
August 21, 2026 15:08
Artem (pararti)
requested review from
MohammadHaroonAbuomar and
liamcrumm
as code owners
August 21, 2026 15:08
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #3785
Problem & Solution
McpAuthPolicy.check()enforcedrequire_tlsonly against the URL supplied by the caller. When the caller omitted that argument, a non-TLS URL already stored in the matchingMcpServerEntrywas never evaluated.This PR selects the effective URL as the caller URL or the configured entry URL. The caller URL retains priority because it describes the connection being checked. If both sources are empty, the existing behavior remains unchanged and the TLS gate is skipped, preserving S10.12 compatibility.
Impact on Your Work
Configured MCP server URLs now receive the same TLS scheme enforcement as caller-supplied URLs.
Timeline
None.
Alternatives Considered
Type of Change
Package(s) Affected
Core & runtime:
Governance & security:
Platform & tooling:
CLI plugins:
Shared / other:
Testing
Unit Testing
Added an 18-case parameterized matrix covering:
require_tls=TrueandFalseManual Testing
git diff --checkpasses. Ruff reports the same four existing file-level findings asmain; none are introduced by the changed lines. The direct conformance module was not collectable in this local checkout because the compiledagent_control_specification._nativemodule is unavailable; the regression matrix directly pins the S10.12 empty-both behavior.Checklist
Attribution & Prior Art
Prior art / related projects (if any):
The configured-URL fallback was previously discussed within this repository in #3512 and was raised again in #3785. No external project code was copied or adapted.
AI Assistance
Codex was used to inspect the issue, draft the regression matrix and minimal patch, and prepare this PR text. All changes were reviewed and explicitly approved by the contributor before submission.
IP, Patents, and Licensing