Make azure_ad_token_provider customizable. #4931
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekzhu
approved these changes
Jan 7, 2025
|
You can run |
jackgerrits
reviewed
Jan 8, 2025
| @@ -472,11 +472,14 @@ def _configure_azure_openai(self, config: Dict[str, Any], openai_config: Dict[st | |||
| openai_config["azure_endpoint"] = openai_config.get("azure_endpoint", openai_config.pop("base_url", None)) | |||
|
|
|||
| # Create a default Azure token provider if requested | |||
| if openai_config.get("azure_ad_token_provider") == "DEFAULT": | |||
There was a problem hiding this comment.
Default is meant to refer to the DefaultAzureCredential, however the parameter that is being changed here is the scope. I feel it should be added as a separate parameter that is correctly named
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, when using azure openai,
azure_ad_token_providerinOAI_CONFIG_LISTcan only take a value of "DEFAULT" which uses the default token provider "https://cognitiveservices.azure.com/.default".This patch would allow users providing custom token providers by setting
azure_ad_token_providerto other values.Checks