-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for markdown file browser to display json files #5463
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will work as-is, and I'll approve it.
Note however that the next version of MarkItDown will support json files, and so we may revisit this.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5463 +/- ##
==========================================
+ Coverage 71.91% 78.62% +6.70%
==========================================
Files 236 167 -69
Lines 11922 10044 -1878
Branches 238 0 -238
==========================================
- Hits 8574 7897 -677
+ Misses 3163 2147 -1016
+ Partials 185 0 -185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Why are these changes needed?
Enable the MarkdownFileBrowser to display '.json' files, such as a package.json file of a react package.
Related issue number
Checks