Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dep on aspire - add google.protobuf #5645

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rysweet
Copy link
Collaborator

@rysweet rysweet commented Feb 21, 2025

Why are these changes needed?

removes unneeded deps

Related issue number

Closes #5644

Checks

@rysweet rysweet changed the title remove dep on aspire - add google.protobug remove dep on aspire - add google.protobuf Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.95%. Comparing base (3a239c5) to head (1397c47).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5645   +/-   ##
=======================================
  Coverage   68.95%   68.95%           
=======================================
  Files         242      242           
  Lines       12435    12435           
  Branches      242      242           
=======================================
  Hits         8574     8574           
  Misses       3672     3672           
  Partials      189      189           
Flag Coverage Δ
unittests 68.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET Agents package should not depend on Aspire
1 participant