Fix #7580 - Add TypeError validation for participants in BaseGroupChat.__init__#7855
Open
Whning0513 wants to merge 1 commit into
Open
Fix #7580 - Add TypeError validation for participants in BaseGroupChat.__init__#7855Whning0513 wants to merge 1 commit into
Whning0513 wants to merge 1 commit into
Conversation
…GroupChat.__init__
Contributor
|
@Whning0513 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Author
|
@microsoft-github-policy-service agree |
2 similar comments
Author
|
@microsoft-github-policy-service agree |
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RoundRobinGroupChat raises raw AttributeError/TypeError for invalid participants instead of a clear validation error
When
participantsis accidentally set toNone, a string, an integer, or a list containing a non-agent object, theRoundRobinGroupChatconstructor raises low-level Python errors such as:TypeError: object of type 'NoneType' has no len()AttributeError: 'str' object has no attribute 'name'These are realistic user mistakes that should produce clear validation errors instead of leaking internal implementation details.
Reported by: emberpath24
The
BaseGroupChat.__init__method (inherited byRoundRobinGroupChat) immediately attempted to calllen(participants)and iterate over participants without validating the type or content of theparticipantsargument first. This caused raw Python runtime errors that were confusing to users.File:
autogen/python/packages/autogen-agentchat/src/autogen_agentchat/teams/_group_chat/_base_group_chat.pyAdded validation checks at the beginning of
BaseGroupChat.__init__:TypeError("At least one participant is required.")iflen(participants) == 0TypeError(f"All participants must be ChatAgent instances, got {type(participant).__name__}")if any participant is not aChatAgentinstanceThese checks ensure users receive clear, actionable error messages when providing invalid input.
Low - The change only adds validation at the top of
__init__before any other logic executes. It does not modify any existing behavior for valid inputs. The validation is minimal and defensive, matching standard Python practices for constructor argument validation.