Fix #7768 - Pop trailing empty AssistantMessage instead of rstrip whitespace mutation#7857
Open
Whning0513 wants to merge 1 commit into
Open
Fix #7768 - Pop trailing empty AssistantMessage instead of rstrip whitespace mutation#7857Whning0513 wants to merge 1 commit into
Whning0513 wants to merge 1 commit into
Conversation
…trip whitespace mutation
Contributor
|
@Whning0513 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Author
|
@microsoft-github-policy-service agree |
2 similar comments
Author
|
@microsoft-github-policy-service agree |
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_rstrip_last_assistant_message only strips trailing whitespace from the content -- it does not remove the assistant message
The
_rstrip_last_assistant_messagemethod only whitespace-strips trailing assistant messages instead of removing them entirely. When the message history genuinely ends with a non-empty assistant message, it passes through unchanged and the Anthropic API rejects it (Anthropic requires the conversation to end with a user message).Reported by: shivase
The original
_rstrip_last_assistant_messagemethod checked if the last message was anAssistantMessagewith empty/whitespace-only content and only popped it if the content was empty after stripping. However, the Anthropic API requires conversations to end with a user message, and any trailing assistant message (even non-empty) causes a rejection.File 1:
autogen/python/packages/autogen-ext/src/autogen_ext/models/anthropic/_anthropic_client.py_rstrip_last_assistant_message()to pop the last message if it is anyAssistantMessage(not just empty ones), using awhileloop to handle consecutive trailing assistant messages.File 2:
autogen/python/packages/autogen-ext/src/autogen_ext/models/openai/_openai_client.py_rstrip_last_assistant_messageis called for model names starting with "claude-" to ensure proper message ordering.Low - The change only affects the edge case where messages end with an assistant message and the target model is Anthropic (or Claude via OpenAI-compatible endpoint). For all other cases, behavior remains identical. Removing trailing assistant messages is semantically safe since the model would generate a new response anyway.