Fix #7157 - Add None guards on tool_call_chunk fields in Azure AI streaming#7858
Open
Whning0513 wants to merge 1 commit into
Open
Fix #7157 - Add None guards on tool_call_chunk fields in Azure AI streaming#7858Whning0513 wants to merge 1 commit into
Whning0513 wants to merge 1 commit into
Conversation
Contributor
|
@Whning0513 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Author
|
@microsoft-github-policy-service agree |
5 similar comments
Author
|
@microsoft-github-policy-service agree |
Author
|
@microsoft-github-policy-service agree |
Author
|
@microsoft-github-policy-service agree |
Author
|
@microsoft-github-policy-service agree |
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AzureAIChatCompletionClient streaming tool_calls can include None fields, causing TypeError
When using
AzureAIChatCompletionClientwith GitHub Models endpoint (https://models.inference.ai.azure.com) and streaming with tool calls enabled, the streaming tool-call aggregation crashes withTypeError: can only concatenate str (not "NoneType") to strbecausetool_call_chunk.id,tool_call_chunk.function.name, ortool_call_chunk.function.argumentscan beNonein streamed deltas.Reported by: daniel-hou-tfs
The Azure AI Inference SDK may emit streaming tool call chunks where individual fields (
id,function.name,function.arguments) areNonein certain deltas. The original code unconditionally concatenated these fields using+=, which raisesTypeErrorwhen the right-hand side isNone.File:
autogen/python/packages/autogen-ext/src/autogen_ext/models/azure/_azure_ai_client.pyAdded None guards before concatenation in the streaming tool-call aggregation loop (around line 550):
if tool_call_chunk.id is not None:beforefull_tool_calls[idx].id += tool_call_chunk.idif tool_call_chunk.function is not None:check for function field existenceif tool_call_chunk.function.name is not None:before name concatenationif tool_call_chunk.function.arguments is not None:before arguments concatenationThis mirrors the pattern already used in the OpenAI client for the same purpose.
Low - The change adds defensive None checks in the streaming aggregation path. It prevents crashes that would otherwise occur with certain API responses and does not modify any existing valid behavior.