Fix #7418 - Preserve extra_body and extra_headers in OpenAI client config deserialization#7859
Open
Whning0513 wants to merge 1 commit into
Open
Fix #7418 - Preserve extra_body and extra_headers in OpenAI client config deserialization#7859Whning0513 wants to merge 1 commit into
Whning0513 wants to merge 1 commit into
Conversation
…ig deserialization (microsoft#7418)
Contributor
|
@Whning0513 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Author
|
@microsoft-github-policy-service agree |
5 similar comments
Author
|
@microsoft-github-policy-service agree |
Author
|
@microsoft-github-policy-service agree |
Author
|
@microsoft-github-policy-service agree |
Author
|
@microsoft-github-policy-service agree |
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extra_body in OpenAIChatCompletionClient config is silently ignored when loaded via AutoGen Studio JSON
When configuring a model client through AutoGen Studio's JSON editor with an
extra_bodyfield (e.g., to passenable_thinking: falseto a Qwen3-compatible endpoint), the field is silently dropped during deserialization. The extra parameters never reach the underlying HTTP request, even though the same configuration works correctly when instantiated directly via Python.Reported by: danmaxis
The
OpenAIChatCompletionClientconfiguration model (_init_config.py) and its deserialization path (_openai_client.py) did not includeextra_bodyorextra_headersin the TypedDict schema or the config forwarding logic. When loading from JSON (e.g., AutoGen Studio'sload_component()), these fields were unrecognized and silently dropped.File 1:
_init_config.pyextra_bodyandextra_headersfields to theCreateArgumentsTypedDict to ensure they are included in the configuration schemaFile 2:
_openai_client.pyOpenAIChatCompletionClientto forwardextra_bodyandextra_headersfrom the config through to the underlying OpenAI API calls in bothcreate()andcreate_stream()methodsLow - The change adds passthrough support for two optional configuration fields that were previously being silently dropped. No existing behavior is modified, and the fields only take effect when explicitly provided by the user.