fix(agentchat): use running loop for sync input callbacks#7865
Open
Ghraven wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asyncio.get_event_loop()withasyncio.get_running_loop()when sync user-input callbacks are executed from async AgentChat pathsUserProxyAgent._get_input()andUserInputManagerso they use the already-running event loop before dispatching work to the executorProblem
These code paths run inside coroutines and only need the active event loop to call
run_in_executor().asyncio.get_event_loop()is a legacy lookup API whose behavior has become stricter across Python versions, whileget_running_loop()is the intended API when a coroutine is already executing.Before / After
Before: sync input callbacks in AgentChat and Console used
asyncio.get_event_loop()from async functions.After: the same callbacks use
asyncio.get_running_loop(), preserving behavior while avoiding the legacy event-loop lookup.Verification
python -m compileall python/packages/autogen-agentchat/src/autogen_agentchat/agents/_user_proxy_agent.py python/packages/autogen-agentchat/src/autogen_agentchat/ui/_console.pygit diff --checkuv run pytest tests/test_userproxy_agent.py -q(5 passed)