Fix the broken always-on-top mode - #2383
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a type mismatch issue in the always-on-top (AOT) mode functionality that was preventing the feature from working correctly due to inconsistent type casting between float and double values.
- Changed the
ToggleAlwaysOnTopmethod signature to acceptdoubleparameters instead offloat - Removed unnecessary type casting when calling the method
- Updated internal type casting to use
doubleconsistently
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Calculator/Views/MainPage.xaml.cs | Removed explicit float casting when calling ToggleAlwaysOnTop method |
| src/Calculator.ManagedViewModels/ApplicationViewModel.cs | Updated method signature and internal casting to use double consistently |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Tian L. (tian-lt)
requested review from
Kenny Guo (guominrui) and
oneonezhang
September 19, 2025 04:54
Kenny Guo (guominrui)
approved these changes
Sep 19, 2025
oneonezhang
approved these changes
Sep 19, 2025
Tian L. (tian-lt)
added a commit
to tian-lt/calculator
that referenced
this pull request
Sep 19, 2025
Tian L. (tian-lt)
added a commit
that referenced
this pull request
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The types for width and height saved in local settings is not matched universally for all the reads and writes. This leads to a type casting failure which blocks the logics to toggle the AOT mode.
Fix
Change the signature of function
ToggleAlwaysOnTopfromTask (float, float)toTask (double, double)