Include guidelines on testing Terraform configuration #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianaivan11
requested review from
TessFerrandez,
shiranr and
nyouens
as code owners
TessFerrandez
approved these changes
Jan 12, 2024
shiranr
approved these changes
Jan 15, 2024
pelleo
pushed a commit
that referenced
this pull request
Jan 22, 2024
Co-authored-by: Shiran Rubin <[email protected]> Co-authored-by: Tess Ferrandez <[email protected]>
TessFerrandez
added a commit
that referenced
this pull request
Jan 22, 2024
This reverts commit 6b0c5b7.
TessFerrandez
added a commit
that referenced
this pull request
Jan 22, 2024
* Revert "Include guidelines on testing Terraform conf (#1019)" This reverts commit 6b0c5b7. * Revert "fix: List rendering broken due missing blank lines (#1018)" This reverts commit 200e839. * Revert "update: vscode gallery repo link (#1017)" This reverts commit ef53433. * Revert "Fix layout issues and add overview pages that are missing in some sections (#1012)" This reverts commit 44bba97. * Revert "fix links (#1020)" This reverts commit 8c0b414.
TessFerrandez
added a commit
that referenced
this pull request
Jan 24, 2024
* Added load test information based on Equinor experience * fix links (#1020) * Fix layout issues and add overview pages that are missing in some sections (#1012) * Fix layout * more cleanup * add explaining text. * updated readme.md with directory of folder. The 3 docs could also be merged instead * fixe a few files * fix a few spelling issues * ignore some acronyms * fix paths * fixing broken paths * fix a few more linking issues * fix links * undo curly brackets * fix two linting errors --------- Co-authored-by: Mark Jervelund <[email protected]> Co-authored-by: Shiran Rubin <[email protected]> * update: vscode gallery repo link (#1017) * update: vscode gallery repo link * update: broken links of ISE blog and Aridhia DRE --------- Co-authored-by: Shiran Rubin <[email protected]> Co-authored-by: Tess Ferrandez <[email protected]> * fix: List rendering broken due missing blank lines (#1018) MkDocs expects documents conform to - MD032 - Lists should be surrounded by blank lines in markdownlint speak. Co-authored-by: Shiran Rubin <[email protected]> Co-authored-by: Tess Ferrandez <[email protected]> * Include guidelines on testing Terraform conf (#1019) Co-authored-by: Shiran Rubin <[email protected]> Co-authored-by: Tess Ferrandez <[email protected]> * Revert "Custom load test client" (#1022) * Revert "Include guidelines on testing Terraform conf (#1019)" This reverts commit 6b0c5b7. * Revert "fix: List rendering broken due missing blank lines (#1018)" This reverts commit 200e839. * Revert "update: vscode gallery repo link (#1017)" This reverts commit ef53433. * Revert "Fix layout issues and add overview pages that are missing in some sections (#1012)" This reverts commit 44bba97. * Revert "fix links (#1020)" This reverts commit 8c0b414. * Fixed typos indicated by lint picker * fix links * Update docs/automated-testing/performance-testing/load-testing.md Co-authored-by: Tomi Paananen <[email protected]> * Update docs/automated-testing/performance-testing/load-testing.md Co-authored-by: Tomi Paananen <[email protected]> * Update docs/automated-testing/performance-testing/load-testing.md Co-authored-by: Tomi Paananen <[email protected]> * Update docs/automated-testing/performance-testing/load-testing.md Co-authored-by: Tomi Paananen <[email protected]> * Update docs/automated-testing/performance-testing/load-testing.md Co-authored-by: Shiran Rubin <[email protected]> * Update docs/automated-testing/performance-testing/load-testing.md Co-authored-by: Shiran Rubin <[email protected]> * Update docs/automated-testing/performance-testing/load-testing.md Co-authored-by: Shiran Rubin <[email protected]> * Update docs/automated-testing/performance-testing/load-testing.md Co-authored-by: Shiran Rubin <[email protected]> * Update docs/automated-testing/performance-testing/load-testing.md Co-authored-by: Shiran Rubin <[email protected]> * Update docs/automated-testing/performance-testing/load-testing.md Co-authored-by: Shiran Rubin <[email protected]> * Update docs/automated-testing/performance-testing/load-testing.md Co-authored-by: Shiran Rubin <[email protected]> * Update docs/automated-testing/performance-testing/load-testing.md Co-authored-by: Shiran Rubin <[email protected]> * Update docs/automated-testing/performance-testing/load-testing.md Co-authored-by: Shiran Rubin <[email protected]> * Update docs/automated-testing/performance-testing/load-testing.md Co-authored-by: Shiran Rubin <[email protected]> * Update docs/automated-testing/performance-testing/load-testing.md Co-authored-by: Shiran Rubin <[email protected]> * Update docs/automated-testing/performance-testing/load-testing.md Co-authored-by: Shiran Rubin <[email protected]> * fix links --------- Co-authored-by: Pelle Olsson <pelleo@pelleonewpc> Co-authored-by: Shiran Rubin <[email protected]> Co-authored-by: Mark Jervelund <[email protected]> Co-authored-by: Mark Jervelund <[email protected]> Co-authored-by: Dilep Dev <[email protected]> Co-authored-by: Tess Ferrandez <[email protected]> Co-authored-by: Mateusz Łoskot <[email protected]> Co-authored-by: Diana Ivan <[email protected]> Co-authored-by: Tess Ferrandez <[email protected]> Co-authored-by: Tomi Paananen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines on testing the Terraform configuration
What are you trying to address
Context:
During our last engagement our crew dedicates some effort into putting together a list of guidelines to what exactly should be tested in a Terraform infrastructure configuration such that the tests are meaningful and bring actual value ( avoid testing for aspects that are already validated through the default Terraform behaviour).
Changes:
Our playbook already contains a page on Terraform structure guidelines here. The guidelines for testing the configuration is the perfect content for another section in the same page, which is the only file updated in this PR.