Set up prettier to run as an eslint rule #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aubreyquinn
approved these changes
Sep 16, 2025
rbitting
force-pushed
the
users/rbitting/prettier-eslint-setup
branch
from
e6c3a84 to
9417493
Compare
rbitting
commented
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, prettier is installed in the repository but nothing is being done with it. Violations are not caught in linting. This PR adds the prettier eslint plugin so that prettier is run as an eslint rule during the established linting process.
Note that, along with having the VS Code Prettier extension format on save of a file, you can programmatically autofix prettier violations (and eslint fixable issues) with:
npm run lint:js -- --fixWhile I was at it, I also added a prettier
singleQuoterule to standardize to always using double quotes for strings. It seemed like that's currently the repository standard, with only a handful of files with violations of single quotes that were easily autofixed.Before:
After:
