Added rule enforcing Image alt text #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbitting
force-pushed
the
users/rbitting/image-rule
branch
from
01de64c to
e3d56bf
Compare
Closed
aubreyquinn
reviewed
Sep 17, 2025
aubreyquinn
reviewed
Sep 17, 2025
rbitting
commented
Sep 17, 2025
rbitting
commented
Sep 17, 2025
aubreyquinn
requested changes
Sep 18, 2025
| * // <img /> | ||
| * hasDefinedProp(attributes, 'src') // false | ||
| */ | ||
| const hasDefinedProp = (attributes: TSESTree.JSXOpeningElement["attributes"], name: string): boolean => { |
Collaborator
There was a problem hiding this comment.
I think there is already a function that checks for a non-empty prop? Maybe that function could be adjusted to include null and undefined checks?
Collaborator
Author
There was a problem hiding this comment.
There's hasNonEmptyProp but adding a flag to that to specifically allow an empty value seemed counter-intuitive. Could rename it from hasNonEmptyProp to hasDefinedProp with a flag to allow non-empty values, but that would require a lot of files to be touched for the name change and I was trying to keep this PR small-ish. If you feel strongly about this I could implement this in a follow-up PR?
rbitting
force-pushed
the
users/rbitting/image-rule
branch
from
936c38c to
7754859
Compare
aubreyquinn
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added rule enforcing Image alt text. Implements #146 .
Example:
Also fixed a linting issue resulting from running the rule creation script, stemming from the last prettier update. Fixes this problem where every line is shown as a linting error: