Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -1 +1,10 @@
{ "recommendations": ["esbenp.prettier-vscode", "dbaeumer.vscode-eslint"] }
{
"recommendations": [
"dbaeumer.vscode-eslint",
"firsttris.vscode-jest-runner",
"esbenp.prettier-vscode",
"rvest.vs-code-prettier-eslint",
"DavidAnson.vscode-markdownlint",
"streetsidesoftware.code-spell-checker-cspell-bundled-dictionaries"
]
}
12 changes: 12 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ or contact [[email protected]](mailto:[email protected]) with any addi

- Install [Visual Studio Code](https://code.visualstudio.com/).

- Install the [recommended plugins](#recommended-vs-code-extensions) for [Visual Studio Code](https://code.visualstudio.com/).

- Install [Node.js](https://nodejs.org/en/), with [nvm](https://github.com/nvm-sh/nvm). Please use Node version 16 and npm v 8.

- Install [jscodeshift](https://github.com/facebook/jscodeshift) globally.
Expand Down Expand Up @@ -49,6 +51,16 @@ or contact [[email protected]](mailto:[email protected]) with any addi

- Make and submit changes following the [pull request submission workflow](#pull-requests)

## Recommended VS Code Extensions

To ensure a consistent and productive development environment, install the following extensions in Visual Studio Code:

- [ESLint](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint) — Linting for JavaScript/TypeScript.
- [Jest Runner](https://marketplace.visualstudio.com/items?itemName=firsttris.vscode-jest-runner) — Run or debug Jest tests from context menu.
- [Prettier - Code formatter](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode) — Code formatting using Prettier.
- [Prettier ESLint](https://marketplace.visualstudio.com/items?itemName=rvest.vs-code-prettier-eslint) — Format code with Prettier and ESLint integration.
- [markdownlint](https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint) — Linting and style checks for Markdown files.

## To create a new ESLint rule

If you want to create a new ESLint rule:
Expand Down
21 changes: 21 additions & 0 deletions KNOWN_ISSUES.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Known Issues

## No object props deconstruction

We currently do not support object props deconstruction.

e.g.

```tsx
const buttonProps = {
icon: <Calendar />,
aria-label: 'start date'
};

<Button {...buttonProps} />

```

Unfortunately, these will not be picked up by our linter. However, we hope to support this soon 🚀

See [issue #149](https://github.com/microsoft/eslint-plugin-fluentui-jsx-a11y/issues/149) for details.
Loading