Skip to content

Updating tests to retry after initial if failed #5094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Updating tests to retry after initial if failed #5094

wants to merge 22 commits into from

Conversation

@jestradaMS
Copy link
Contributor

@jestradaMS jestradaMS commented Aug 13, 2025 •
edited by azure-boards bot
Loading

Description

This PR introduces retries to Unit test, Integration and E2E tests to reduce need to manually retry if transient errors occurring during execution of tests.

Related issues

Addresses AB#166378.

Testing

Describe how this change was tested.

Ran PR against local users branch

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@jestradaMS jestradaMS requested a review from a team as a code owner August 13, 2025 14:35
@jestradaMS jestradaMS changed the title Updating tests to retry after initial Updating tests to retry after initial if failed Aug 13, 2025
@jestradaMS jestradaMS added this to the CY25Q3/2Wk07 milestone Aug 13, 2025
LTA-Thinking
LTA-Thinking reviewed Aug 13, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 19, 2025
View reviewed changes
src/Microsoft.Health.Extensions.Xunit/SimpleRetryFactDiscoverer.cs

if (maxRetries <= 1)
{
return new[] { new XunitTestCase(_diagnosticMessageSink, discoveryOptions.MethodDisplayOrDefault(), discoveryOptions.MethodDisplayOptionsOrDefault(), testMethod) };

Check warning

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning

Disposable 'XunitTestCase' is created but not disposed.

Copilot Autofix

AI about 2 months ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LTA-Thinking LTA-Thinking LTA-Thinking left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Build

Projects

None yet

Milestone

CY25Q3/2Wk07

Development

Successfully merging this pull request may close these issues.

2 participants

@jestradaMS @LTA-Thinking