Skip to content

Fix for include and revinclude searches for v2 scopes with search par… #5185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 58 commits into from
Closed

Fix for include and revinclude searches for v2 scopes with search par… #5185

wants to merge 58 commits into from

Conversation

@apurvabhaleMS
Copy link
Contributor

@apurvabhaleMS apurvabhaleMS commented Oct 9, 2025

…ameters

Description

Describe the changes in this PR.

Related issues

Addresses [issue #].

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

feordin and others added 30 commits August 4, 2025 12:48
@feordin
Add SMART v2 scopes
a2e891c
@feordin
Update Unit tests
99cab33
@feordin
Additional checks for DataActions and tests
4f252be
@feordin
Add more checks and more tests based on code review comments
706d8e3
@feordin
Shortended test code with theories
3ab05ab
@apurvabhaleMS
SMART V2 Granular scoprs
6acd55c
@feordin
Add conditional handler tests
1be8a24
@feordin
Condense tests, add .http file
5c0f09f
@feordin
Update opendiddict for fewer scopes and fhirUser claim. Update .http …
f34189a 
…file for SMART v2
@feordin
Associate Export with 's' V2 scope
a808623
@feordin
Updates for code review comments, and rename DataAction
2aee086
@feordin
Merge branch 'main' into personal/jaerwin/smartv2-scopes
dd97fbd
@feordin
Fix incorrect data Action in test
29c3884
@feordin
Use POST method in SMART test
d12f882
@feordin
Merge branch 'personal/jaerwin/smartv2-scopes' of https://github.com/…
ef54d55 
…microsoft/fhir-server into personal/jaerwin/smartv2-scopes
@feordin
Fix Bundle references
2ae2683
@feordin
Remove access denied tests from SmartSearchTests as they are covered …
1d49897 
…in ResourceHanlder tests
@feordin
Add null check
6bd0b78
@feordin
update test case
ee0d13d
@feordin
Adjust test to account for varying resource counts
d3b2a33
@feordin
One more test case fix
ed0fc2a
@feordin
Fix test bugs
c9fafce
@feordin @github-advanced-security
Potential fix for code scanning alert no. 2652: String concatenation …
02c0be8 
…in loop

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@feordin
fix string building issues
2e6f849
@feordin
Fix check access bug for search
1be5870
@feordin
Fix check access on SearchCompartmentHandler which was not updated fo…
fc7b9bf 
…r SMART v2
@apurvabhaleMS
SMART V2 Granular scope update and tests
6127cb7
@apurvabhaleMS
Fix unit tests
b564bc8
@apurvabhaleMS
Merge branch 'main' into personal/jaerwin/smartv2-scopes
60e97dc
@apurvabhaleMS
Merge remote-tracking branch 'origin/main' into personal/jaerwin/smar…
8de89f5 
…tv2-scopes

# Conflicts:
#	test/Microsoft.Health.Fhir.Shared.Tests.Integration/Features/Smart/SmartSearchTests.cs
apurvabhaleMS and others added 27 commits September 29, 2025 10:47
@apurvabhaleMS
Merge remote-tracking branch 'origin/main' into personal/jaerwin/smar…
34e6507 
…tv2-scopes
@apurvabhaleMS
Fix SL Options Factory unit tests
33b9390
@apurvabhaleMS
FIx suggestions
e85f1fa
@apurvabhaleMS
Tests
cd9782a
@apurvabhaleMS
Fix tests
0b2e2bb
@apurvabhaleMS
Merge remote-tracking branch 'origin/main' into personal/jaerwin/smar…
78bd7c1 
…tv2-scopes

# Conflicts:
#	src/Microsoft.Health.Fhir.Tests.Common/TestFiles/R4/SmartPatientA.json
#	test/Microsoft.Health.Fhir.Shared.Tests.Integration/Features/Smart/SmartSearchTests.cs
@apurvabhaleMS
Fix conflicts
92f54a5
@apurvabhaleMS
Fix failing tests
cab997a
@apurvabhaleMS
Fix failing tests
1d76bbb
@apurvabhaleMS
clean up tests
30db265
@apurvabhaleMS
clean up tests
3c1f705
@apurvabhaleMS
Compartment search tests
1460b2b
@apurvabhaleMS
Throw 400 if chained, include or revinclude request with ApplyFineGra…
2eafdf1 
…inedAccessControlWithSearchParameters
@apurvabhaleMS
Updates to rest test file
a3e6c21
@apurvabhaleMS
Comments and clean up
c02dec6
@apurvabhaleMS
fix conflicts
2f1978d
@apurvabhaleMS
Merge remote-tracking branch 'origin/main' into personal/jaerwin/smar…
86eb982 
…tv2-scopes

# Conflicts:
#	src/Microsoft.Health.Fhir.Api/Resources.resx
@apurvabhaleMS
Merge remote-tracking branch 'origin/main' into personal/jaerwin/smar…
7f26a69 
…tv2-scopes

# Conflicts:
#	src/Microsoft.Health.Fhir.Shared.Core.UnitTests/Features/Search/SearchOptionsFactoryTests.cs
#	src/Microsoft.Health.Fhir.Shared.Core/Features/Search/SearchOptionsFactory.cs
@apurvabhaleMS
Fixes
28a76b7
@apurvabhaleMS
Fix unit tests
d0f2dda
@feordin
Add include tests
e550b17
@apurvabhaleMS
Added searchParam to equality comparer and fix tests
1f6de98
@apurvabhaleMS
Fix unit tests
14d69e1
@apurvabhaleMS
Fix for include and revinclude searches for v2 scopes with search par…
cc65c9f 
…ameters
@apurvabhaleMS
More tests
e2c3256
@apurvabhaleMS
More tests
8a4d199
@apurvabhaleMS
Chain search test
6707ad1
Base automatically changed from personal/jaerwin/smartv2-scopes to main October 17, 2025 22:19
@apurvabhaleMS apurvabhaleMS deleted the personal/abhale/include-revinclude-smart-v2 branch November 6, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apurvabhaleMS @feordin