-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Pr help/burtonsmith/add cem to wc library #34198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Hotell
wants to merge
10
commits into
microsoft:master
Choose a base branch
from
Hotell:pr_help/burtonsmith/add-cem-to-wc-library
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
15271d9
create custom elements manifest for web components project
2ab7ccf
add changeset
ded2c3e
Update packages/web-components/src/avatar/avatar.ts
break-stuff de2fc0c
add dev experience section to README.ms
bdf5bd3
add global dependencies
d27ef70
ran yarn-deduplicate
8364467
run formatter
37c6e30
fix formatting
1003d6c
update file format
f934b29
chore: dedupe
Hotell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@fluentui-web-components-712d19ac-cecc-4674-a955-28e95a3fb602.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "prerelease", | ||
"comment": "Added custom elements manifest to project and included it in published package", | ||
"packageName": "@fluentui/web-components", | ||
"email": "[email protected]", | ||
"dependentChangeType": "patch" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
test-results/ | ||
custom-elements.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
packages/web-components/custom-elements-manifest.config.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
import { modulePathResolverPlugin } from '@wc-toolkit/module-path-resolver'; | ||
import { cemValidatorPlugin } from '@wc-toolkit/cem-validator'; | ||
import { getTsProgram, typeParserPlugin } from '@wc-toolkit/type-parser'; | ||
import { cemInheritancePlugin } from '@wc-toolkit/cem-inheritance'; | ||
|
||
export default { | ||
/** Globs to analyze */ | ||
globs: ['src/**/*.ts'], | ||
/** Globs to exclude */ | ||
exclude: [ | ||
'_docs/**/*', | ||
'src/**/*.bench.ts', | ||
'src/**/*.definition.ts', | ||
'src/**/*.options.ts', | ||
'src/**/*.spec.ts', | ||
'src/**/*.stories.ts', | ||
'src/**/*.styles.ts', | ||
'src/**/*.template.ts', | ||
'src/**/define.ts', | ||
'src/**/index.ts', | ||
], | ||
/** Enable special handling for fast */ | ||
fast: true, | ||
/** Provide custom plugins */ | ||
plugins: [ | ||
modulePathResolverPlugin({ | ||
modulePathTemplate: (modulePath, name, tagName) => `./dist/esm/${getBaseTag(tagName)}/${getBaseTag(tagName)}.js`, | ||
definitionPathTemplate: (modulePath, name, tagName) => `./dist/esm/${getBaseTag(tagName)}/define.js`, | ||
typeDefinitionPathTemplate: (modulePath, name, tagName) => `./dist/dts/${getBaseTag(tagName)}/index.d.ts`, | ||
}), | ||
typeParserPlugin(), | ||
cemInheritancePlugin(), | ||
cemValidatorPlugin({ | ||
rules: { | ||
packageJson: { | ||
main: 'off', | ||
module: 'off', | ||
types: 'off', | ||
}, | ||
manifest: { | ||
schemaVersion: 'off', | ||
}, | ||
}, | ||
}), | ||
], | ||
|
||
/** Overrides default module creation: */ | ||
overrideModuleCreation({ ts, globs }) { | ||
const program = getTsProgram(ts, globs, 'tsconfig.json'); | ||
return program.getSourceFiles().filter(sf => globs.find(glob => sf.fileName.includes(glob))); | ||
}, | ||
}; | ||
|
||
function getBaseTag(tagName) { | ||
return tagName?.replace('fluent-', ''); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Positioning 2 screenshots
vr-tests-web-components/Accordion 1 screenshots
vr-tests-web-components/Badge 1 screenshots
vr-tests-web-components/Checkbox 1 screenshots
vr-tests-web-components/MenuList 2 screenshots
vr-tests-web-components/Switch 1 screenshots
vr-tests-web-components/TextInput 1 screenshots
vr-tests/Callout 2 screenshots
vr-tests/Keytip 2 screenshots
vr-tests/react-charting-AreaChart 1 screenshots
vr-tests/react-charting-LineChart 4 screenshots
There were 1 duplicate changes discarded. Check the build logs for more information.