Semantic-Tokens: React-Link #34218
Open
Semantic-Tokens: React-Link #34218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request demo site: URL |
| }, | ||
| }, | ||
|
|
||
| // Semantic-tokens does not include inverted tokens, use existing tokens for now. | ||
| inverted: { | ||
| color: tokens.colorBrandForegroundInverted, |
There was a problem hiding this comment.
Wondering if we should bring this to the group to figure out what we want our stance on things like this to be. Should it be handled through theme or do we need explicit semantic tokens here as well?
There was a problem hiding this comment.
Current stance is that inverted tokens should be avoided in semantic to avoid unnecessary complexity, and that a local variant theme or style override (optionally using custom style hooks) should be localized to the intended component (currently inverted tokens are only used in link and toast headers)
Mitch-At-Work
force-pushed
the
user/mifraser/link-semantic-tokens
branch
from
43a6cef to
e929366
Compare
mainframev
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates React-link to use semantic tokens
To be landed after #34217
Extended tokens branch will be PR'd against master to validate via bundle size tool.
Previous Behavior
React-link used existing fluentui/tokens set
New Behavior
React-link now uses fluentui/semantic-tokens set