fix(react-button): update active state styles to include keyboard press events #35514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mainframev
approved these changes
Nov 25, 2025
jurokapsiar
reviewed
Nov 25, 2025
| }, | ||
|
|
||
| ':hover:active': { | ||
| ':hover:active,:active:focus-visible': { |
Contributor
There was a problem hiding this comment.
pls use Fluent UI focus indicator
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
I'm not totally sure that's feasible here, since I'd have to duplicate all the :active styles - unless I'm overlooking something? Also, I don't actually need the focus outline styles here, just want to fix this edge case.
Contributor
Author
There was a problem hiding this comment.
@jurokapsiar, could you clarify why you think we should use the focus indicator style hooks here? Just so we're on the same page, this update isn’t about styling the focus state - it’s just for applying the :active state to the button, either when the clicks on the button and the pointer’s over it (introduced in #22574) or when a user presses space/enter while the button’s focused (this PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Button's active state is only visible when mouse is hovering a button (introduced in #22574)
Demo - active state is not visible when button is focused and a user presses space:
Screen.Recording.2025-11-25.at.9.59.29.mov
New Behavior
Button's active state is visible when mouse is hovering a button or when the button has
:focus-visible. This allows us to show active state on keyboard press without breaking the behavior introduced #22574Demo - active state is visible when mouse is hovering a button or when a user presses "space" on focused button
Screen.Recording.2025-11-25.at.9.58.38.mov
Related Issue(s)