fix(instructions): define CI configuration provenance - #2846
Open
Bill Berry (WilliamBerryiii) wants to merge 1 commit into
Open
fix(instructions): define CI configuration provenance#2846Bill Berry (WilliamBerryiii) wants to merge 1 commit into
Bill Berry (WilliamBerryiii) wants to merge 1 commit into
Conversation
Fixes #2838 🔒 - Generated by Copilot
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2846 +/- ##
==========================================
+ Coverage 83.14% 83.24% +0.09%
==========================================
Files 183 172 -11
Lines 34039 34350 +311
Branches 27 0 -27
==========================================
+ Hits 28302 28594 +292
- Misses 5734 5756 +22
+ Partials 3 0 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Eval Execution✅ Status: Passed — no merge-blocking failures (2 advisory assertion failure(s) present)
|
Jamie Kim (jkim323)
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(instructions): define CI configuration provenance
Description
Updated the Bash authoring guidance so repository-managed CI configuration is treated as executable code whose authority comes from the reviewed repository revision and checkout. The guidance now fails closed when the authorized configuration is absent and keeps operator-managed, user-selected, and externally acquired configuration outside this contract.
Related Issue(s)
Fixes #2838
Type of Change
Select all that apply:
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
hve-builderand addressed all actionable findings.github/instructions/*.instructions.md).github/prompts/*.prompt.md).github/agents/*.agent.md).github/skills/*/SKILL.md).github/hooks/*/*.json)evals/)Other:
.ps1,.sh,.py)Sample Prompts (for AI Artifact Contributions)
User Request:
Author or review a Bash script that sources repository-managed CI configuration.
Execution Flow:
Output Artifacts:
The instruction directly creates no artifact. It governs Bash content and reviews for matching
.shfiles.Success Indicators:
Generated or reviewed guidance uses reviewed-checkout authority, identifies substitution and post-checkout modification as invalidating events, fails when authorized configuration is absent, and preserves the separate policy boundary for non-CI configuration.
For detailed contribution requirements, see:
Testing
Checklist
Required Checks
docs/file changed)AI Artifact Contributions
hve-builderreview mode to review contributionhve-builderreviewRequired Local Checks
The following local-safe validation commands must pass before merging:
npm run validate:localnpm run validate:docsnpm run spell-checknpm run lint:md-linksSecurity Considerations
Additional Notes
The
.ci/config.shpath is illustrative; this PR does not add or claim an existing runtime configuration file. The change defines authoring guidance, not a runtime verification mechanism. Local aggregate and link validation remain unchecked because external requests stalled; hosted CI must provide the final link-check result. Package-wide P08 acceptance and non-CI configuration policy remain outside this PR.