fix: PptxConverter tolerates None shape.text and notes text#2059
Open
alvinttang wants to merge 1 commit into
Open
fix: PptxConverter tolerates None shape.text and notes text#2059alvinttang wants to merge 1 commit into
alvinttang wants to merge 1 commit into
Conversation
shape.text and notes_text_frame.text can return None for runs with no <a:t> child or certain third-party decks. Treat None as empty string so one malformed shape does not fail the whole file. Refs microsoft#1808
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1808.
PptxConverter.convertdoes unguarded+/.lstrip()onshape.textandnotes_text_frame.text. python-pptx returnsNonefor a text frame whose<a:r>run has no<a:t>child, and for certain third-party-generated decks. One malformed shape then fails the whole file withAttributeError: 'NoneType' object has no attribute 'lstrip'orTypeError: can only concatenate str (not "NoneType") to str.Fix: treat
Nonetext as empty string at all three sites (title shape, body shape, notes frame).RED
GREEN
Full
test_module_vectors.py(109 tests, covers real pptx conversion) still passes.