Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate existing enclave session during connection (re)connect #2638

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

machavan
Copy link
Contributor

Description:

For AE with secure enclave, the driver connections receives an error 33195 - Internal enclave error. Enclave was provided with an invalid session handle. For more information, contact Customer Support Services, post failovers ( in case of Always On setup).

This could be happening because of driver using existing enclave session from the enclaveCache in the driver.

This fix invalidates the existing enclave session as part of the connect method.

@github-project-automation github-project-automation bot moved this to In progress in MSSQL JDBC Mar 26, 2025
@machavan machavan changed the title Invalidate existing enclave session in during (re)connect Invalidate existing enclave session during connection (re)connect Mar 26, 2025
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 51.47%. Comparing base (9caba4d) to head (781f4b5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 18.18% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2638      +/-   ##
============================================
- Coverage     51.52%   51.47%   -0.06%     
+ Complexity     3990     3987       -3     
============================================
  Files           147      147              
  Lines         33706    33718      +12     
  Branches       5631     5635       +4     
============================================
- Hits          17366    17355      -11     
- Misses        13886    13908      +22     
- Partials       2454     2455       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@lilgreenbird lilgreenbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants