Inital StackCookie implementation for MSVC AARCH64 #1221
Conversation
github-actions
bot
added
the
impact:non-functional
| @@ -0,0 +1,80 @@ | |||
| ;------------------------------------------------------------------------------ | |||
| ; AARCH64/StackCheckFunctionsMsvc.nasm | |||
There was a problem hiding this comment.
| ; AARCH64/StackCheckFunctionsMsvc.nasm | |
| ; AARCH64/StackCheckFunctionsMsvc.asm | |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #1221 +/- ##
===========================================
Coverage 1.59% 1.59%
===========================================
Files 1449 1449
Lines 362730 362730
Branches 5632 5632
===========================================
Hits 5776 5776
Misses 356847 356847
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
|
not stale |
|
This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
|
This pull request has been automatically been closed because it did not have any activity in 60 days and no follow up within 7 days after being marked stale. Thank you for your contributions. |
3 participants
Description
MSVC AARCH64 /GS support is untested. When it is enabled, the StackCheckLibNull does not satisfy the required externs required by the linker.
Adding support to StackCheckibNull for MSVC.
How This Was Tested
Compilation passes.
Integration Instructions
No changes required