[REBASE&FF] ReportStatusCode: Always cache protocol before usage #1602
+330
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javagedes
force-pushed
the
personal/joeyvagedes/report-status-code-lib-test
branch
from
afb96fb to
dbb5edc
Compare
apop5
reviewed
Dec 17, 2025
apop5
reviewed
Dec 17, 2025
MdeModulePkg/Library/DxeReportStatusCodeLib/ReportStatusCodeLib.c
Outdated
Show resolved
Hide resolved
Javagedes
force-pushed
the
personal/joeyvagedes/report-status-code-lib-test
branch
3 times, most recently
from
ed956ed to
89ea636
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/202502 #1602 +/- ##
=================================================
Coverage ? 1.32%
=================================================
Files ? 802
Lines ? 306180
Branches ? 2120
=================================================
Hits ? 4051
Misses ? 302109
Partials ? 20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
os-d
approved these changes
Dec 17, 2025
Contributor
os-d
left a comment
os-d
left a comment
There was a problem hiding this comment.
Can you take this to edk2, too?
Contributor
Author
ya, I will. Figured we wanted this here first though |
makubacki
reviewed
Dec 17, 2025
MdeModulePkg/Library/DxeReportStatusCodeLib/ReportStatusCodeLib.c
Outdated
Show resolved
Hide resolved
MdeModulePkg/Library/DxeReportStatusCodeLib/TestDxeReportStatusCodeLibTestApp.c
Outdated
Show resolved
Hide resolved
MdeModulePkg/Library/DxeReportStatusCodeLib/TestDxeReportStatusCodeLibTestApp.h
Outdated
Show resolved
Hide resolved
Javagedes
force-pushed
the
personal/joeyvagedes/report-status-code-lib-test
branch
from
89ea636 to
3c7de8c
Compare
kuqin12
reviewed
Dec 18, 2025
MdeModulePkg/Library/DxeReportStatusCodeLib/TestDxeReportStatusCodeLibTestApp.c
Show resolved
Hide resolved
Javagedes
force-pushed
the
personal/joeyvagedes/report-status-code-lib-test
branch
2 times, most recently
from
b938184 to
27ce6c2
Compare
Contributor
Author
|
I have re-requested all reviews, as I have made a fundamental change to the pull request. |
Javagedes
force-pushed
the
personal/joeyvagedes/report-status-code-lib-test
branch
from
27ce6c2 to
e7f73d1
Compare
makubacki
approved these changes
Dec 18, 2025
1 task
kuqin12
approved these changes
Dec 18, 2025
Javagedes
force-pushed
the
personal/joeyvagedes/report-status-code-lib-test
branch
3 times, most recently
from
fbd8e25 to
4994b4c
Compare
Javagedes
force-pushed
the
personal/joeyvagedes/report-status-code-lib-test
branch
4 times, most recently
from
95f48c7 to
ccc6b80
Compare
kuqin12
approved these changes
Dec 18, 2025
Javagedes
force-pushed
the
personal/joeyvagedes/report-status-code-lib-test
branch
4 times, most recently
from
663f9ac to
75c5980
Compare
apop5
approved these changes
Dec 23, 2025
This commit adds a UEFI_APPLICATION unit test for DxeReportStatusCodeLib that ensures that the platform does not invert the TPL on an initial call to ReportStatusCode functionality. This functionality has the potential to invert the TPL due to the fact that on an initial call to report status code functionality, if the EFI_STATUS_CODE protocal has not been located, it will attempt to locate it. LocateProtocol performs a tpl raise to EFI_NOTIFY. If the caller of ReportStatusCode is in a TPL higher then EFI_NOTIFY, we will invert the TPL and assert.
This commit stops the library for querying the protocol database for the status code protocol at the time of use of the library function. This logic can result in a TPL inversion if the protocol has not yet been located and the caller is running in a TPL higher then TPL_NOTIFY. Instead, the protocol is now located during construction of the library during driver startup. If the protocol is not found, then an on-protocol install event is registered. A deconstructor is also added to close the event in the case that the driver is unloaded before the protocol is installed.
This commit stops the library for querying the protocol database for the status code protocol at the time of use of the library function. This logic can result in a TPL inversion if the protocol has not yet been located and the caller is running in a TPL higher then TPL_NOTIFY. Instead, the protocol is now located during construction of the library during driver startup. If the protocol is not found, then an on-protocol install event is registered. A deconstructor is also added to close the event in the case that the driver is unloaded before the protocol is installed.
Javagedes
force-pushed
the
personal/joeyvagedes/report-status-code-lib-test
branch
from
75c5980 to
4ebfdfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit stops the library for querying the protocol database for the
status code protocol at the time of use of the library function. This
logic can result in a TPL inversion if the protocol has not yet been
located and the caller is running in a TPL higher then TPL_NOTIFY.
Instead, the protocol is now located during construction of the library
during driver startup. If the protocol is not found, then an on-protocol
install event is registered. A deconstructor is also added to close the
event in the case that the driver is unloaded before the protocol is
installed.
This PR is a rebase and fast forward as it includes a new test.
How This Was Tested
Integration Instructions
N/A