Skip to content

Sync Mu DevOps Files, add new cargo checks, and fix resulting errors #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
makubacki merged 9 commits into from
Aug 25, 2025
Merged

Sync Mu DevOps Files, add new cargo checks, and fix resulting errors #739

makubacki merged 9 commits into from
Aug 25, 2025

Conversation

@magravel
Copy link
Contributor

@magravel magravel commented Aug 19, 2025 •
edited by makubacki
Loading

Description

This pull request brings rust fmt/clippy/doc/test validation to pull requests. Initial fixes for these are also included in this PR.

The file sync commit was cherry-picked from this pull request: #737

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

This was tested by running the PR pipeline ( clippy, fmt, build, test, coverage, doc ).

Integration Instructions

N/A

@mu-automation mu-automation bot added the impact:non-functional Does not have a functional impact label Aug 19, 2025
magravel
magravel commented Aug 19, 2025
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (dev/202502@14e6097). Learn more about missing BASE report.

Additional details and impacted files 
@@              Coverage Diff              @@
##             dev/202502     #739   +/-   ##
=============================================
  Coverage              ?   11.47%           
=============================================
  Files                 ?      136           
  Lines                 ?    22094           
  Branches              ?     2514           
=============================================
  Hits                  ?     2536           
  Misses                ?    19526           
  Partials              ?       32
Flag Coverage Δ
AdvLoggerPkg 6.18% <ø> (?)
HidPkg 2.79% <ø> (?)
MfciPkg 41.24% <ø> (?)
MsCorePkg 1.41% <ø> (?)
MsWheaPkg 7.40% <ø> (?)
XmlSupportPkg 27.38% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@magravel magravel mentioned this pull request Aug 19, 2025
Closed
@magravel magravel changed the title Fix for devops sync Synced file(s) with microsoft/mu_devops and Fix for devops sync Aug 20, 2025
@magravel magravel changed the title Synced file(s) with microsoft/mu_devops and Fix for devops sync Synced file(s) with microsoft/mu_devops and rust fixes. Aug 20, 2025
@magravel magravel changed the title Synced file(s) with microsoft/mu_devops and rust fixes. Synced file(s) with microsoft/mu_devops and Cargo fixes. Aug 21, 2025
@magravel magravel marked this pull request as ready for review August 21, 2025 16:34
@makubacki makubacki changed the title Synced file(s) with microsoft/mu_devops and Cargo fixes. Repo File Sync: Add RustCargoSteps.yml and fix Rust files to pass checks Aug 21, 2025
makubacki
makubacki reviewed Aug 21, 2025
View reviewed changes
makubacki
makubacki reviewed Aug 21, 2025
View reviewed changes
makubacki
makubacki reviewed Aug 21, 2025
View reviewed changes
makubacki
makubacki reviewed Aug 21, 2025
View reviewed changes
makubacki
makubacki reviewed Aug 21, 2025
View reviewed changes
@magravel magravel force-pushed the magravel/fix-for-devops-sync branch 6 times, most recently from ff125f8 to dba5893 Compare August 21, 2025 23:22
@makubacki
Copy link
Member

makubacki commented Aug 21, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 21, 2025

Azure Pipelines successfully started running 2 pipeline(s).

@magravel
Copy link
Contributor Author

magravel commented Aug 22, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 22, 2025

Commenter does not have sufficient privileges for PR 739 in repo microsoft/mu_plus

@makubacki
Copy link
Member

makubacki commented Aug 22, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 22, 2025

Azure Pipelines successfully started running 2 pipeline(s).

@makubacki makubacki force-pushed the magravel/fix-for-devops-sync branch from c1e566b to bcac1d9 Compare August 22, 2025 17:33
@makubacki
Copy link
Member

makubacki commented Aug 22, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 22, 2025

Azure Pipelines successfully started running 2 pipeline(s).

@makubacki makubacki changed the title Repo File Sync: Add RustCargoSteps.yml and fix Rust files to pass checks Sync Mu DevOps Files, add new cargo checks, and fix resulting errors Aug 25, 2025
makubacki
makubacki reviewed Aug 25, 2025
View reviewed changes
@makubacki
Copy link
Member

makubacki commented Aug 25, 2025

@magravel, please fill in the "How this was tested section" in the PR description.

makubacki
makubacki reviewed Aug 25, 2025
View reviewed changes
@mu-automation mu-automation bot added the type:backport Backport changes in a dev branch PR to its release branch. label Aug 25, 2025
@makubacki makubacki merged commit d6b4cca into microsoft:dev/202502 Aug 25, 2025
30 checks passed
mu-automation bot pushed a commit that referenced this pull request Aug 25, 2025
@magravel @makubacki @ProjectMuBot
[CONFLICT] Sync Mu DevOps Files, add new cargo checks, and fix result…
cc4d9be 
…ing errors (#739)

## Description

This pull request brings rust fmt/clippy/doc/test validation to pull
requests. Initial fixes for these are also included in this PR.

The file sync commit was cherry-picked from this pull request:
#737

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?
- [x] Backport to release branch?

## How This Was Tested

This was tested by running the PR pipeline ( clippy, fmt, build, test,
coverage, doc ).

## Integration Instructions

N/A

Co-authored-by: Michael Kubacki <[email protected]>
apop5 pushed a commit to apop5/mu_plus that referenced this pull request Sep 11, 2025
@magravel @makubacki @apop5
Sync Mu DevOps Files, add new cargo checks, and fix resulting errors (m…
ee5bcc2 
…icrosoft#739)

## Description

This pull request brings rust fmt/clippy/doc/test validation to pull
requests. Initial fixes for these are also included in this PR.

The file sync commit was cherry-picked from this pull request:
microsoft#737

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?
- [x] Backport to release branch?

## How This Was Tested

This was tested by running the PR pipeline ( clippy, fmt, build, test,
coverage, doc ).

## Integration Instructions

N/A

Co-authored-by: Michael Kubacki <[email protected]>
apop5 pushed a commit to apop5/mu_plus that referenced this pull request Sep 11, 2025
@magravel @makubacki @apop5
Sync Mu DevOps Files, add new cargo checks, and fix resulting errors (m…
06158a8 
…icrosoft#739)

## Description

This pull request brings rust fmt/clippy/doc/test validation to pull
requests. Initial fixes for these are also included in this PR.

The file sync commit was cherry-picked from this pull request:
microsoft#737

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?
- [x] Backport to release branch?

## How This Was Tested

This was tested by running the PR pipeline ( clippy, fmt, build, test,
coverage, doc ).

## Integration Instructions

N/A

Co-authored-by: Michael Kubacki <[email protected]>
Javagedes pushed a commit that referenced this pull request Sep 17, 2025
@magravel @makubacki @Javagedes
Sync Mu DevOps Files, add new cargo checks, and fix resulting errors (#…
f6e6e0e 
…739)

This pull request brings rust fmt/clippy/doc/test validation to pull
requests. Initial fixes for these are also included in this PR.

The file sync commit was cherry-picked from this pull request:
#737

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?
- [x] Backport to release branch?

This was tested by running the PR pipeline ( clippy, fmt, build, test,
coverage, doc ).

N/A

Co-authored-by: Michael Kubacki <[email protected]>
apop5 pushed a commit to apop5/mu_plus that referenced this pull request Sep 17, 2025
@magravel @makubacki @apop5
Sync Mu DevOps Files, add new cargo checks, and fix resulting errors (m…
41b430c 
…icrosoft#739)

## Description

This pull request brings rust fmt/clippy/doc/test validation to pull
requests. Initial fixes for these are also included in this PR.

The file sync commit was cherry-picked from this pull request:
microsoft#737

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?
- [x] Backport to release branch?

## How This Was Tested

This was tested by running the PR pipeline ( clippy, fmt, build, test,
coverage, doc ).

## Integration Instructions

N/A

Co-authored-by: Michael Kubacki <[email protected]>
apop5 pushed a commit that referenced this pull request Sep 18, 2025
@magravel @makubacki @apop5
Sync Mu DevOps Files, add new cargo checks, and fix resulting errors (#…
b43a8d3 
…739)

## Description

This pull request brings rust fmt/clippy/doc/test validation to pull
requests. Initial fixes for these are also included in this PR.

The file sync commit was cherry-picked from this pull request:
#737

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?
- [x] Backport to release branch?

## How This Was Tested

This was tested by running the PR pipeline ( clippy, fmt, build, test,
coverage, doc ).

## Integration Instructions

N/A

Co-authored-by: Michael Kubacki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@makubacki makubacki makubacki approved these changes

@apop5 apop5 apop5 approved these changes

Assignees

No one assigned

Labels

impact:non-functional Does not have a functional impact type:backport Backport changes in a dev branch PR to its release branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@magravel @codecov-commenter @makubacki @apop5