Skip to content

UefiHidDxeV2: fix cargo clippy issues for toolchain 1.92.0 #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apop5 merged 2 commits into from
Dec 15, 2025
Merged

UefiHidDxeV2: fix cargo clippy issues for toolchain 1.92.0 #804

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95f79f5
UefiHidDxeV2: fix cargo clippy issues for toolchain 1.92.0
antklein Dec 12, 2025
f478c77
Merge branch 'release/202502' into rust_toolchain1.92_support
apop5 Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions HidPkg/UefiHidDxeV2/src/pointer/absolute_pointer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,14 +351,14 @@ mod test {

// expected on PointerHidHandler::initialize().
boot_services.expect_create_event().returning(|_, _, wait_for_ptr, context, event_ptr| {
if wait_for_ptr.is_none() {
// This is a test, so we expect the wait_for_pointer function to be set.
panic!("wait_for_pointer function should be set");
} else {
if let Some(value) = wait_for_ptr {
assert!(ptr::fn_addr_eq(
wait_for_ptr.unwrap(),
value,
PointerContext::wait_for_pointer as extern "efiapi" fn(efi::Event, *mut c_void)
));
} else {
// This is a test, so we expect the wait_for_pointer function to be set.
panic!("wait_for_pointer function should be set");
}
assert_ne!(context, ptr::null_mut());
unsafe {
Expand Down Expand Up @@ -436,14 +436,14 @@ mod test {

// expected on PointerHidHandler::initialize().
boot_services.expect_create_event().returning(|_, _, wait_for_ptr, context, event_ptr| {
if wait_for_ptr.is_none() {
// This is a test, so we expect the wait_for_pointer function to be set.
panic!("wait_for_pointer function should be set");
} else {
if let Some(value) = wait_for_ptr {
assert!(ptr::fn_addr_eq(
wait_for_ptr.unwrap(),
value,
PointerContext::wait_for_pointer as extern "efiapi" fn(efi::Event, *mut c_void)
));
} else {
// This is a test, so we expect the wait_for_pointer function to be set.
panic!("wait_for_pointer function should be set");
}
assert_ne!(context, ptr::null_mut());
unsafe {
Expand Down Expand Up @@ -528,14 +528,14 @@ mod test {

// expected on PointerHidHandler::initialize().
boot_services.expect_create_event().returning(|_, _, wait_for_ptr, context, event_ptr| {
if wait_for_ptr.is_none() {
// This is a test, so we expect the wait_for_pointer function to be set.
panic!("wait_for_pointer function should be set");
} else {
if let Some(value) = wait_for_ptr {
assert!(ptr::fn_addr_eq(
wait_for_ptr.unwrap(),
value,
PointerContext::wait_for_pointer as extern "efiapi" fn(efi::Event, *mut c_void)
));
} else {
// This is a test, so we expect the wait_for_pointer function to be set.
panic!("wait_for_pointer function should be set");
}
assert_ne!(context, ptr::null_mut());
unsafe {
Expand Down