MfciPkg: Fix MfciDxeRoT unit test. #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apop5
changed the title
mu-automation
bot
added
impact:non-functional
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202502 #805 +/- ##
=================================================
Coverage ? 34.04%
=================================================
Files ? 17
Lines ? 1877
Branches ? 528
=================================================
Hits ? 639
Misses ? 1225
Partials ? 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Javagedes
reviewed
Dec 12, 2025
Unit tests are failing due to use of setjump/longjump. There are multiple bug reports about the use of setjump/longjump when dealing with address sanitizer. There are a lot of false positives triggered because the address sanitizer is unable to verify the stack when it is directly manipulated. Fixing the failing case by removing setjump/longjump from the failing unit test.
apop5
force-pushed
the
personal/apop5/mfciunittests
branch
from
f2833fa to
dee3d47
Compare
Javagedes
approved these changes
Dec 12, 2025
Flickdm
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unit tests are failing due to use of setjump/longjump.
There are multiple bug reports about the use of setjump/longjump when dealing with address sanitizer. There are a lot of false positives triggered because the address sanitizer is unable to verify the stack when it is directly manipulated.
Fixing the failing case by removing setjump/longjump from the failing unit test.
How This Was Tested
Pipeline is failing.
Local CI fails.
After integrating changes, local CI is passing.
Integration Instructions
No Integration necessary.