Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: opt-out for nogc finalizer change #59

Merged
merged 2 commits into from
Apr 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "native-keymap",
"version": "3.3.4",
"version": "3.3.5",
"description": "Get OS key mapping",
"main": "index.js",
"typings": "index.d.ts",
6 changes: 3 additions & 3 deletions pipeline.yml
Original file line number Diff line number Diff line change
@@ -34,13 +34,13 @@ extends:
testPlatforms:
- name: Linux
nodeVersions:
- 18.17.x
- 20.x
- name: MacOS
nodeVersions:
- 18.17.x
- 20.x
- name: Windows
nodeVersions:
- 18.17.x
- 20.x

testSteps:
# https://github.com/nodejs/node-gyp/issues/2869
1 change: 1 addition & 0 deletions src/keymapping.cc
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

#define NODE_API_EXPERIMENTAL_NOGC_ENV_OPT_OUT
#include <node.h>
#include <map>