Skip to content

Add MIGraphX execution provider support#2069

Open
aditya-dl wants to merge 6 commits intomicrosoft:mainfrom
aditya-dl:amd/dev/adilohia/migraphx_support
Open

Add MIGraphX execution provider support#2069
aditya-dl wants to merge 6 commits intomicrosoft:mainfrom
aditya-dl:amd/dev/adilohia/migraphx_support

Conversation

@aditya-dl
Copy link
Copy Markdown

Summary

Adds MIGraphX (AMD GPU) execution provider support to ONNX Runtime GenAI.

  • Register MIGraphX EP using the per-provider session_options architecture (V2 plugin path with V1 legacy fallback)
  • Enable graph capture for MIGraphX to allow compiled graph reuse during token generation
  • Add static input shape padding (prompt_gen_ flag) so MIGraphX avoids recompilation on varying prompt lengths
  • Fix input_ids padding to handle both int32 and int64 element types, and correct per-row copy for batch_size > 1
  • Fix position_ids padding to prevent out-of-bounds read on next_tokens when tensor shape is padded to max_length for batch_size > 1

How it works

MIGraphX requires static input dimensions to avoid expensive recompilation. During prompt processing, input_ids, position_ids, and logits are padded to max_length. During token generation, shapes are [batch, 1] and graph capture is enabled. The attention mask is padded via the existing InitializeStaticMask path (triggered by graph capture).

MIGraphX loads as a shared provider via the V1 AppendExecutionProvider path. When the plugin EP (V2) becomes available, the same code will work through the V2 path automatically.

Known limitations

  • Beam search not supported (requires past_present_share_buffer=true which requires num_beams=1)
  • Inputs allocated on CPU; MIGraphX EP handles CPU↔GPU transfers internally
  • No is_migraphx_available() runtime detection yet

amd-adilohia and others added 5 commits April 3, 2026 20:01
Register MIGraphX as an execution provider following the new
per-provider session_options architecture. Creates
src/migraphx/session_options.{h,cpp} with AppendExecutionProvider
that tries V2 plugin path then falls back to V1 legacy API.

Adds provider name normalization ("migraphx" -> "MIGraphX") and
registers in the dispatch table and cmake build.
The MIGraphX static padding in State::Run() hardcoded int64_t* for
data access regardless of actual element type, only zeroed the first
batch row, and used a flat copy loop ignoring per-batch-row strides.

Fix dispatches on elem_type for int32/int64, zeros the entire padded
tensor, and copies each batch row with correct source/dest strides.
When prompt_gen_ pads position_ids_shape_ to max_length, the function
used shape[1] (max_length) to index into next_tokens which only has
new_length elements per row, causing out-of-bounds reads for
batch_size>1.

Add seq_length parameter to separate actual token count from padded
tensor shape. Zero-fill the full tensor upfront and populate only the
real token positions per row.
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

@aditya-dl please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

The prompt_gen_ flag was set unconditionally in AppendTokens(),
causing all EPs (CUDA, DML, WebGPU, etc.) to pad inputs to
max_length during prompt processing. This is only needed for
MIGraphX to avoid recompilation on varying input shapes.

Add NeedsStaticInputShapes() config query that returns true only
when MIGraphX is the configured provider. Cache the result as
use_static_input_shapes on GeneratorParams (following the same
pattern as use_graph_capture and use_multi_profile). Set
prompt_gen_ from this flag instead of unconditional true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants