Fix #24130 by adding an empty dependency group to the code that generates Microsoft.ML.OnnxRuntime.nuspec #24131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamin-hodgson
changed the title
|
/azp run Big Models, Linux Android Emulator QNN CI Pipeline, Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline |
|
/azp run Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
Azure Pipelines successfully started running 8 pipeline(s). |
snnn
approved these changes
Mar 21, 2025
|
I think this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As detailed in the issue (#24130), the Microsoft.ML.OnnxRuntime nuspec needs an additional dependency group for the
nativeTFM, to allow it to be referenced viaPackageReferencein vcxproj projects.I took a peek at the code after filing the issue, since it seemed like it ought to be a simple fix. It looks like the nuspec file for the
Microsoft.ML.OnnxRuntimepackage is generated by the python code ingenerate_nuspec_for_native_nuget.py, so I just added a line of code there.However I'm not sure how the build system invokes this generator so I haven't been able to test it in situ. Let me know if this isn't the right fix!
Motivation and Context
See detailed description in #24130