fix: restore const on UriSafeString::from_static#328
Merged
kate-shine merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 168 168
Lines 11903 11902 -1
=======================================
- Hits 11903 11902 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Vaiz
approved these changes
Mar 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Restores const support for UriSafeString::from_static so it can be used in compile-time contexts, and updates related examples/tests accordingly.
Changes:
- Make
UriSafeString::from_staticapub const fn. - Update unit test to validate
from_staticworks in aconstcontext. - Reformat the
BaseUri::with_originrustdoc example for readability.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/templated_uri/src/uri_safe.rs | Restores const fn on from_static and updates the test to use a const value. |
| crates/templated_uri/src/base_uri.rs | Reformats doctest example to a multi-line call style. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
martintmk
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.