fix(conda build): revert noarch and add playwright install test#2792
fix(conda build): revert noarch and add playwright install test#2792mxschmitt merged 6 commits intomicrosoft:mainfrom
Conversation
|
@microsoft-github-policy-service agree |
|
What I'm still confused a bit about is why #2794 is still passing - do you have a clue why this is the case? |
|
I wonder if the Github Actions ubuntu runner perhaps just doesn't have the necessary browser dependencies (I have seen something like this elsewhere). I will try with |
|
@mxschmitt it seems this needs your approval to re-run. When you get a moment, could we try the latest change, either here or on #2794, if that's easier? |
|
😕 Well shucks. I can try actually building this locally in an Ubuntu container, to reproduce this error. Will check back with any findings. |
|
Update: I have been able to repro this locally. Will follow up shortly with a fix. |
|
@mxschmitt thanks for jumping in here. I was able to repro the prior error on an ubuntu container, but couldn't figure out how to fix it 🤷 |
|
Thanks @mxschmitt!! |
closes #2791
Starting by just adding the failing test case proposed by @mxschmitt in #2791 (comment)
, to prove to ourselves that ci will fail with this additional test.Oops, ci doesn't run without maintainer approval, that makes sense!I've gone ahead and implemented your proposed changes as best I understood them, @mxschmitt! Thanks for the prompt review and direction on this. Happy to adjust if you like, or feel free to push to this branch directly if you prefer. 🙏