Open
Support string[] and Buffer in stringPlayable block#6976
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Support string array and Buffer in stringPlayable block
Support string[] and Buffer in stringPlayable block
Jun 26, 2026
abchatra
marked this pull request as ready for review
June 26, 2026 23:42
Collaborator
|
Fixes #6965 |
Collaborator
|
@copilot where is agent debug logs |
Contributor
Author
The agent session logs are available in the GitHub Actions tab of the repository. Navigate to Actions → find the workflow run triggered by this PR → open the job to see the step-by-step execution logs. You can also track sessions via the Copilot session tracking page as described in the Tracking GitHub Copilot's sessions docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stringPlayableonly acceptedstring, while the underlyingStringArrayPlayableconstructor already handledstring | string[] | Buffer. This mismatch prevented callers from passing note arrays or Buffers through the block API.Changes
libs/core/playable.ts: WidenedstringPlayableparameter type fromstringtostring | string[] | Buffer— no logic change needed sinceStringArrayPlayablealready dispatches correctly for all three typeslibs/core/_locales/core-jsdoc-strings.json: Updated the generated locale string to reflect the new accepted typesExample