Update rust to 1.93.0, and upgrade rust dependencies#3020
Open
joao-boechat wants to merge 9 commits intomainfrom
Open
Update rust to 1.93.0, and upgrade rust dependencies#3020joao-boechat wants to merge 9 commits intomainfrom
joao-boechat wants to merge 9 commits intomainfrom
Conversation
billti
reviewed
Mar 17, 2026
minestarks
approved these changes
Mar 17, 2026
minestarks
reviewed
Mar 17, 2026
idavis
reviewed
Mar 18, 2026
| @@ -366,10 +366,11 @@ impl UpdateWorker<'_> { | |||
|
|
|||
| async fn apply_this_and_pending(&mut self, mut updates: Vec<Update>) { | |||
Contributor
Author
There was a problem hiding this comment.
@idavis try_next was deprecated by rust (docs), so we have to use try_recv, which returns Result<T, TryRecvError> instead of Result<Option<T>, TryRecvError>. So now, when the channel is closed, instead of returning None, it will return TryRecvError::Closed, and I had to pattern match that case in order to keep the behavior unchanged. Since I'm using loop now, I had to also consider the case TryRecvError::Empty to break out of it, which happened automatically in the while loop conditional before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
miette to 7.6
pyo3 to 0.28
ndarray to 0.17
rust to 1.93