Skip to content

Conversation

ms-lolo
Copy link
Contributor

@ms-lolo ms-lolo commented Jul 12, 2025

not yet ready but the below command works as an example

rats-aml submit-cmd --wait -- echo hello world

cc. @jzazo

Copy link

codecov bot commented Jul 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 46.53%. Comparing base (e2bf289) to head (17f68a6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rats-devtools/src/rats/aml/_app.py 0.00% 40 Missing ⚠️
Additional details and impacted files
Components Coverage Δ
rats-apps ∅ <ø> (∅)
rats-devtools ∅ <ø> (∅)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@jzazo jzazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR about having a cli to submit arbitrary commands does not work towards my desired API where we have control over what to submit.

What it does though is skip the submit application ids logic, but by duplicating that logic.

Ideally, thinking about the API logic, I would add services (fallback) that allow you to provide a command object, a sweep object, or a pipeline for example (and maybe more in the future). If you do not provide a command job, you can provide default inputs, outputs, image, etc.

For example, have a command job container that has all the services that you want to expose from containers. A user may want to provide those services, or provide the command job service directly... That way we would give the user full control, while still having nice defaults if desired.

What do you think?

Comment on lines +572 to +576
cli_command = cli.Command(
cwd=self._app.get(AppConfigs.CLI_CWD),
argv=tuple([*args]),
env=env,
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in a lower level API, the right abstraction for submitting arbitrary commands should be tuple[str, ...], and no cwd and no env.

Reason of why this is important is because the user should control the appearance of what actually shows remotely, if they are to debug it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants