Add support for accessibilityDescription prop. #14585
Conversation
…ion of TextInput.
…lementation of TextInput." This reverts commit bbe8b68.
| @@ -117,6 +117,22 @@ export default class Bootstrap extends React.Component< | |||
| <Text style={styles.text}>TEST setAccessibilityFocus</Text> | |||
| </TouchableHighlight> | |||
| <TextInput ref={this.myElement} /> | |||
|
|
|||
| <TouchableHighlight | |||
There was a problem hiding this comment.
We typically leave these sample pages as they are. If you want to add an example of the prop, add an example to a JS/TS file in the rntester app (i.e. the files that have the *Example syntax). I would add an example to AccessibilityExampleWindows.tsx
|
This is not the right implementation. What we want to do here is create a new prop called accessibilityDescription that should only be available on Windows. This prop should accept a string. The value of this prop should be used to add data to the UIA property UIA_FullDescriptionPropertyId. It looks like what you've done here is add the value of the accessibilityHint prop to the UIA property UIA_FullDescriptionPropertyId. We should not be using the accessibilityHint property at all here. Also we shouldn't need to make any edits to AbiViewProps for this change. We don't need a default value. If the value is unspecified, we should simply pass the empty string to UIA_FullDescriptionPropertyId. |
|
@satkh PRs should be coming from our own forked repository instead of a branch off main! More instructions are on our contributing.md page in this repo |
Description
Add support for accessibilityDescription prop. This property should populate the UIA Help Text property. (UIA_FullDescriptionPropertyId)
Type of Change
Why
Resolves #14578
What
Screenshots
Testing
Verified on Accessibility Insights for Windows
Changelog
Should this change be included in the release notes: yes
Add a brief summary of the change to use in the release notes for the next release.
Microsoft Reviewers: Open in CodeFlow