Cleanup unneeded ReactCommon patching, and extra hostplatform overrides #14697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoates-ms
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated React.Cpp.Props to have include paths for our platform overrides, followed by the various cxx platform directories from core. This ensures that we are consistently including our platform overrides, and only if they do not exist, including the cxx version in core.
This allowed us to remove a bunch of unneeded patching of ReactCommon.
Part of this involved dealing with our override of TextLayoutManager, which isn't a platform overridable file, instead we can inherit from the core implementation, and then inject our version into the contextContainer in FabricUIManagerModule, which allows TextInput and Paragraph to access the correct TextLayoutManager.
Type of Change
Why
Cleanup of a bunch of unnecessary forked code that we were replacing in react-native.
Resolves #13391
Resolves #14674
Resolves #14216
Resolves #14131
Resolves #14692
Resolves #14664
Microsoft Reviewers: Open in CodeFlow