-
Notifications
You must be signed in to change notification settings - Fork 653
Extract CredentialCache from Rush into @rushstack/credential-cache #5421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dmichon-msft
merged 14 commits into
microsoft:main
from
dmichon-msft:extract-credential-cache
Oct 23, 2025
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
dcae0f9
Add new credential-cache package
dmichon-msft b0d4184
Add test command
dmichon-msft 59023ee
Factor out CredentialCache
dmichon-msft 5dc4d8d
Fix routing
dmichon-msft aa5d645
Fix API
dmichon-msft ca34e09
Update readme
dmichon-msft 06ae754
Update readme
dmichon-msft eaed80d
rush update
dmichon-msft ffad4c8
Forward rush-user folder name
dmichon-msft 1bf994c
Remove old credentials schema
dmichon-msft dee98a9
Restore caching in getHomeFolder
dmichon-msft 24b1ffd
Remove reexport of areDeepEqual
dmichon-msft 21dc28c
Update API md
dmichon-msft 080f45f
Centralize polyfill
dmichon-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
common/changes/@microsoft/rush/extract-credential-cache_2025-10-22-01-44.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@microsoft/rush", | ||
| "comment": "Extract CredentialCache API out into \"@rushstack/credential-cache\". Reference directly in plugins to avoid pulling in all of \"@rushstack/rush-sdk\" unless necessary.", | ||
| "type": "none" | ||
| } | ||
| ], | ||
| "packageName": "@microsoft/rush" | ||
| } |
10 changes: 10 additions & 0 deletions
10
common/changes/@rushstack/credential-cache/extract-credential-cache_2025-10-22-01-44.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@rushstack/credential-cache", | ||
| "comment": "Create dedicated package for the Rush \"CredentialCache\" API. This API manages credential persistence on the local machine.", | ||
| "type": "minor" | ||
| } | ||
| ], | ||
| "packageName": "@rushstack/credential-cache" | ||
| } |
10 changes: 10 additions & 0 deletions
10
common/changes/@rushstack/node-core-library/extract-credential-cache_2025-10-22-01-44.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@rushstack/node-core-library", | ||
| "comment": "Add \"Objects.areDeepEqual\" and \"User.getHomeFolder\" APIs.", | ||
| "type": "minor" | ||
| } | ||
| ], | ||
| "packageName": "@rushstack/node-core-library" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 23 additions & 12 deletions
35
common/config/subspaces/build-tests-subspace/pnpm-lock.yaml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush. | ||
| { | ||
| "pnpmShrinkwrapHash": "1dc2b69423ca353582cec8716410a0b8a8210aff", | ||
| "pnpmShrinkwrapHash": "c9e998d8d98c587075f2380a11aa0816aecfd2fc", | ||
| "preferredVersionsHash": "550b4cee0bef4e97db6c6aad726df5149d20e7d9", | ||
| "packageJsonInjectedDependenciesHash": "7bf222162008849ca931709cbaa90632d56766da" | ||
| "packageJsonInjectedDependenciesHash": "9c50330f156d5d74c5dd1fb2e3aa6b9c2a2403c7" | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| ## API Report File for "@rushstack/credential-cache" | ||
|
|
||
| > Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/). | ||
| ```ts | ||
|
|
||
| // @public (undocumented) | ||
| export class CredentialCache implements Disposable { | ||
| // Warning: (ae-forgotten-export) The symbol "SYMBOL_DISPOSE" needs to be exported by the entry point index.d.ts | ||
| // | ||
| // (undocumented) | ||
| [SYMBOL_DISPOSE](): void; | ||
| // (undocumented) | ||
| deleteCacheEntry(cacheId: string): void; | ||
| // (undocumented) | ||
| dispose(): void; | ||
| // (undocumented) | ||
| static initializeAsync(options: ICredentialCacheOptions): Promise<CredentialCache>; | ||
| // (undocumented) | ||
| saveIfModifiedAsync(): Promise<void>; | ||
| // (undocumented) | ||
| setCacheEntry(cacheId: string, entry: ICredentialCacheEntry): void; | ||
| // (undocumented) | ||
| trimExpiredEntries(): void; | ||
| // (undocumented) | ||
| tryGetCacheEntry(cacheId: string): ICredentialCacheEntry | undefined; | ||
| // (undocumented) | ||
| static usingAsync(options: ICredentialCacheOptions, doActionAsync: (credentialCache: CredentialCache) => Promise<void> | void): Promise<void>; | ||
| } | ||
|
|
||
| // @public (undocumented) | ||
| export interface ICredentialCacheEntry { | ||
| // (undocumented) | ||
| credential: string; | ||
| // (undocumented) | ||
| credentialMetadata?: object; | ||
| // (undocumented) | ||
| expires?: Date; | ||
| } | ||
|
|
||
| // @public (undocumented) | ||
| export interface ICredentialCacheOptions { | ||
| // (undocumented) | ||
| cacheFilePath?: string; | ||
| // (undocumented) | ||
| supportEditing: boolean; | ||
| } | ||
|
|
||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.