.Net: Initial pass for native aot annotations for inmemory connector. #11100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Microsoft.SemanticKernel.Connectors.InMemory warns if using NativeAOT.
This PR contributes to #10256, and helps make SK NativeAOT compatible.
Description
In the InMemory project, I've turned PublishAot to true, then built the project.
This shows a number of warnings. This PR solves all of those warning but the JsonSerializer ones, that are part of a longer discussion in the linked issue. The solution is to simply annotate the calling methods/types/generic definitions with the suggested attributes, which now bubble up to any possible callers, allowing the linker to not remove some specific methods/ctors.
Contribution Checklist