Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Update Agent invoke abstraction parameters #11192

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

TaoChenOSU
Copy link
Contributor

@TaoChenOSU TaoChenOSU commented Mar 25, 2025

Motivation and Context

Now that our agents have a more aligned interface, we can move the common interface parameters to the abstract class.

Description

Move the messages and thread parameters to the abstract class Agent for the get_response, invoke, and invoke_stream methods.

Contribution Checklist

@TaoChenOSU TaoChenOSU added the python Pull requests for the Python Semantic Kernel label Mar 25, 2025
@TaoChenOSU TaoChenOSU self-assigned this Mar 25, 2025
@TaoChenOSU TaoChenOSU requested a review from a team as a code owner March 25, 2025 15:43
@github-actions github-actions bot changed the title Update Agent invoke abstraction parameters Python: Update Agent invoke abstraction parameters Mar 25, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Mar 25, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/agents
   agent.py1502285%46, 53, 57, 66–77, 124, 129, 134, 139, 144, 148, 152, 156, 305–307, 374
semantic_kernel/agents/autogen
   autogen_conversable_agent.py1171587%68, 74, 86, 88, 93–97, 278–279, 288–291
semantic_kernel/agents/bedrock
   bedrock_agent.py2505478%77–84, 93, 159, 286, 299, 318, 334–337, 343, 345, 348, 353, 383, 396, 428–448, 452, 482, 495, 514–517, 519–522, 564, 575–576, 588, 624–635, 646, 663–676, 693–702
   bedrock_agent_base.py1454370%103, 121–122, 147, 160–162, 189, 208–210, 215, 234–236, 241, 245–246, 266–268, 277, 296–300, 305, 324–328, 333, 345–347, 359–381
semantic_kernel/agents/channels
   bedrock_agent_channel.py79297%208–209
TOTAL21224246188% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3335 5 💤 0 ❌ 0 🔥 1m 40s ⏱️

@TaoChenOSU TaoChenOSU enabled auto-merge March 25, 2025 17:17
@TaoChenOSU TaoChenOSU added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit ad5026f Mar 25, 2025
30 checks passed
@TaoChenOSU TaoChenOSU deleted the taochen/update-agent-invoke-interface-param branch March 25, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents python Pull requests for the Python Semantic Kernel
Projects
Status: Sprint: Done
Development

Successfully merging this pull request may close these issues.

4 participants