Skip to content

.Net: Rename IsFilterable to IsIndexed and IsFullTextSearchable to IsFullTextIndexed #11441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 9, 2025
Merged

.Net: Rename IsFilterable to IsIndexed and IsFullTextSearchable to IsFullTextIndexed #11441

merged 6 commits into from
Apr 9, 2025

Conversation

westey-m
Copy link
Contributor

@westey-m westey-m commented Apr 8, 2025

Motivation and Context

#11130

Description

Rename IsFilterable to IsIndexed and IsFullTextSearchable to IsFullTextIndexed

Contribution Checklist

@westey-m westey-m requested a review from a team as a code owner April 8, 2025 13:04
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory labels Apr 8, 2025
@github-actions github-actions bot changed the title Rename IsFilterable to IsIndexed and IsFullTextSearchable to IsFullTextIndexed .Net: Rename IsFilterable to IsIndexed and IsFullTextSearchable to IsFullTextIndexed Apr 8, 2025
roji
roji approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

adamsitnik
adamsitnik approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @westey-m !

@westey-m westey-m merged commit 8a132c0 into microsoft:feature-vector-data-preb2 Apr 9, 2025
11 checks passed
@westey-m westey-m added the needs_port_to_python Indicate this item needs to also be done for Python label Apr 16, 2025
@github-actions github-actions bot mentioned this pull request Apr 16, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

@adamsitnik adamsitnik adamsitnik approved these changes

@dmytrostruk dmytrostruk dmytrostruk approved these changes

Assignees
No one assigned
Labels
kernel Issues or pull requests impacting the core kernel memory needs_port_to_python Indicate this item needs to also be done for Python .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@westey-m @roji @adamsitnik @dmytrostruk @markwallace-microsoft