Skip to content

Conversation

MehakBindra
Copy link
Contributor

@MehakBindra MehakBindra commented Sep 17, 2025

skip-test-verification

  1. Oauth in Typescript - verified in local and dev
  2. Basic in typescript Dev env (switched from managed identity back to client id and secret - single tenant)
    For managed identity we would have had to update each template to use azure identity
  3. Remove conversion of port to number as ports are strings in dev env

@MehakBindra MehakBindra changed the title TS Changes for atk.basic in azure and atk.oauth TS Changes for atk.basic in azure and atk.oauth Sep 17, 2025
Copy link
Contributor

@heyitsaamir heyitsaamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, we also need to create a Service Principal for the target tenant. As such, the app becomes unusable, unless the user manually does this. ATK has this slated for next week, so we shouldn't do the single-tenant switch just yet.

Copy link
Contributor

@heyitsaamir heyitsaamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested TS, and PY.
For posterity's sake, we decided to go with this approach because:

  1. Local echo bot works as before
  2. Oauth and Dev require service principals to be created. Right now, we are going to make documentation changes to let users do this on Azure portal, but ATK is going to add this as part of their CLI next(ish) week.

@heyitsaamir heyitsaamir merged commit add6c50 into main Sep 18, 2025
10 checks passed
@heyitsaamir heyitsaamir deleted the mehak/ts-cli branch September 18, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants