feat(cards): support lowercase and capitalized JSON values for Spacing #373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
Spacing
type and the JSON schema to support both lowercase and capitalized values for thespacing
property in Adaptive Cards. This addresses the inconsistency between the Adaptive Cards Designer, which uses capitalized values, and the linter in this repository, which prefers lowercase values.Changes
packages/cards/src/core.ts
: Added lowercase and camelCase variants to theSpacing
type definition.packages/cards/schema.json
: Updated the regex for13.columnSpacing
to includeExtraSmall
and its variants.Rationale
This change avoids confusion for developers and improves the developer experience by allowing either casing to be used for the
spacing
property. Both capitalized and lowercase values are rendered correctly in Teams, so this change makes the SDK more flexible.Fixes #132